TestResumableRequestHeaderTooMuchFailures: prepare for Go 1.14 changes#40470
Merged
tiborvass merged 1 commit intomoby:masterfrom Feb 10, 2020
Merged
TestResumableRequestHeaderTooMuchFailures: prepare for Go 1.14 changes#40470tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
This was referenced Feb 7, 2020
Merged
cpuguy83
reviewed
Feb 10, 2020
Go 1.14 adds quotes around the invalid scheme in the error returned in golang/go@64cfe9f Go 1.13: Get I%27m%20not%20an%20url: unsupported protocol scheme "" Go 1.14: Get "I%27m%20not%20an%20url": unsupported protocol scheme "" This patch updates the test to detect both versions of the error Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
loosen_error_check_assert
branch
from
cf1b545 to
6acfc42
Compare
tiborvass
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40434
relates to #40353
Go 1.14 adds quotes around the invalid scheme in the error returned (See golang/go@64cfe9f and golang/go#29261)
Go 1.13:
Go 1.14:
This patch updates the test to detect both versions of the error