Fix windows cross builds.#40439
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 1, 2020
Merged
Conversation
thaJeztah
reviewed
Jan 30, 2020
cpuguy83
force-pushed
the
fix_windows_cross
branch
from
50fabe0 to
a0380a0
Compare
Windows still writes to the autogen directory, but the source code is mounted in as read-only. In order to do enable this without taking a massive hit in doing an rw mount (for the source code) we mount a tmpfs into the build at the autogen dir. In order for this to work the directory must alreay exist, so we create it before entering the build. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fix_windows_cross
branch
from
a0380a0 to
5dffe74
Compare
Member
Author
|
And fixed typo that you will now never see 🎉 |
Member
|
I'll bring this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows still writes to the autogen directory, but the source code is
mounted in as read-only.
In order to do enable this without taking a massive hit in doing an rw
mount (for the source code) we mount a tmpfs into the build at the
autogen dir.
In order for this to work the directory must alreay exist, so we create
it before entering the build.
Fixes #40438