Fix leak related to service logs#40426
Merged
Merged
Conversation
See the commit message for the new swarmkit commit. That change fixes a leaking goroutine related to service logs. Signed-off-by: Drew Erny <[email protected]>
thaJeztah
added
area/swarm
impact/changelog
kind/bugfix
Member
|
aaah, whoops, didn't see your PR, and opened #40431 let me close mine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: moby/swarmkit@ef128ab...49e3561
changes:
- What I did
Bump swarmkit version to 49e3561
Includes the fix described in moby/swarmkit#2926.
- Description for the changelog
Fixed an issue where service logs could leak goroutines on the worker.