Skip to content

hack/make/.go-autogen: fix typo in LDFLAGS variable #40389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuguy83 merged 1 commit into from
Jan 17, 2020
Merged

hack/make/.go-autogen: fix typo in LDFLAGS variable #40389

cpuguy83 merged 1 commit into from
Jan 17, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 17, 2020

Introduced in 675b414 (#40180)

@thaJeztah
hack/make/.go-autogen: fix typo in LDFLAGS variable
e8122ed 
Introduced in 675b414

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah requested a review from cpuguy83 January 17, 2020 11:41
@thaJeztah thaJeztah requested a review from tianon as a code owner January 17, 2020 11:41
@thaJeztah thaJeztah mentioned this pull request Jan 17, 2020
Merged
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 17, 2020

@tonistiigi @cpuguy83 PTAL

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 17, 2020

Looks like a flaky test on Windows (RS5)
https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-40389/runs/1/nodes/52/log/?start=0

=== FAIL: github.com/docker/docker/integration-cli TestDockerSuite/TestStartAttachMultipleContainers (62.16s)
    --- FAIL: TestDockerSuite/TestStartAttachMultipleContainers (62.16s)
        cli.go:29: assertion failed:
            Command:  d:\CI\PR-40389\1\binary\docker.exe run -d --name test2 busybox sleep 240
            ExitCode: 125
            Error:    exit status 125
            Stdout:   ee5370488006df8953720d813098f010f9eab324d15b828e8dcdd85a4b4d340f

            Stderr:   d:\CI\PR-40389\1\binary\docker.exe: Error response from daemon: hcsshim::PrepareLayer - failed failed in Win32: The device is not ready. (0x15).


            Failures:
            ExitCode was 125 expected 0
            Expected no error

tianon
tianon approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😅

cpuguy83
cpuguy83 approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oy... LGTM.

@cpuguy83 cpuguy83 merged commit ac95277 into moby:master Jan 17, 2020
@thaJeztah thaJeztah deleted the fix_autogen_typo branch January 17, 2020 16:41
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees

No one assigned

Labels

area/project kind/bugfix PR's that fix bugs status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @tianon @cpuguy83