Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eca42bb to
0bd88c0
Compare
0bd88c0 to
da46849
Compare
|
Some more test-changes are needed looks like; Interesting; validation somehow failed; |
|
Ok, problem looks to be with swagger-gen; root@b5beaed18589:/go/src/github.com/docker/docker# ./hack/generate-swagger-api.sh
2020/02/07 15:12:01 trying to read config from /go/src/github.com/docker/docker/api/swagger-gen.yaml
2020/02/07 15:12:02 rendering 1 templates for model ErrorResponse
2020/02/07 15:12:02 name field ErrorResponse
2020/02/07 15:12:02 package field types
2020/02/07 15:12:02 creating "error_response.go" in "api/types" as definition
model: template: schematype:2:18: executing "schemaType" at <(len .AllOf) gt 0>: can't give argument to non-function len .AllOf |
da46849 to
f8f6d0e
Compare
f8f6d0e to
5bb2ffa
Compare
|
The go-swagger error is coming from https://github.com/kolyshkin/go-swagger/blob/12f14135e4076c9ee21897fe64598062af3c3ef1/generator/templates/schematype.gotmpl#L2 Might actually be a regression in Go? |
|
hm why is it still failing on this one? Or do we have two tests with this problem? |
57808d7 to
91cac41
Compare
|
Interesting failure in a unit test; opened #40496 |
1ada09f to
9b760f3
Compare
|
Whoop, green! So, final step would be to fix |
263f119 to
dbd8865
Compare
|
One failure in a unit test; |
|
The test failure sounds like the following change in Go 1.14:
The CL is here: https://golang.org/cl/206124 EDIT: this appears to be fixed in upstream swagger (see the order of the "gt" in https://github.com/go-swagger/go-swagger/blob/master/generator/templates/schematype.gotmpl) |
1348193 to
bcbd787
Compare
8fee344 to
8ae23d7
Compare
|
Rebased, and updated to golang 1.16.5 |
|
More flakiness? failures in Details |
|
Failing again (but only on arm64). Wondering if it's a change in Go 1.16.5 revealing an issue (I saw @cpuguy83 made some changes to the test, but already commented the test is "dubious") |
8ae23d7 to
d1ca30d
Compare
|
Wondering if the TestParallel failures are related to Go 1.16.5; golang/go@go1.16.4...go1.16.5 Trying reverting to Go 1.16.4 (temporary commit) |
|
Nope.. same failures on Go 1.16.4 |
d1ca30d to
cc3da9a
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
result of: `hack/vendor.sh archive/tar` Signed-off-by: Sebastiaan van Stijn <[email protected]>
cc3da9a to
3ed804a
Compare
|
There is not enough space on the disk.
There is not enough space on the disk. |
Issue mentioned upstream at <moby/moby#40353>, there was a tentative fix at <moby/moby#40496>, but the issue is still present. === Failed === FAIL: pkg/signal TestCatchAll (0.00s) signal_linux_test.go:32: assertion failed: urgent I/O condition (string) != hangup (string) signal_linux_test.go:32: assertion failed: hangup (string) != child exited (string) signal_linux_test.go:32: assertion failed: child exited (string) != illegal instruction (string) signal_linux_test.go:32: assertion failed: illegal instruction (string) != floating point exception (string) signal_linux_test.go:32: assertion failed: floating point exception (string) != child exited (string) Gbp-Pq: Name test--skip-pkg-signal-flaky-tests.patch


Just testing if there's regressions / issues with Go
1.141.15depends on:
TestCatchAll, TestStopCatch: remove unneeded goroutine #40496 Fix race condition in TestCatchAllRemove local fork of Golang's archive/tar #42402 (if possible) Remove local fork of Golang's archive/tar(nice to have - not needed for updating)