Skip to content

update vendor golang.org/x/sys#40274

Closed
XiaodongLoong wants to merge 0 commit intomoby:masterfrom
XiaodongLoong:master
Closed

update vendor golang.org/x/sys#40274
XiaodongLoong wants to merge 0 commit intomoby:masterfrom
XiaodongLoong:master

Conversation

@XiaodongLoong
Copy link
Contributor

@XiaodongLoong XiaodongLoong commented Nov 29, 2019

execute "docker run -it {image name} /bin/sh" no response on mip64el platform;
EpollEvent struct define lack a field named PadFd;
add the field "PadFd";
execcute docker run -it {image} /bin/sh for test after rebuilded.

AkihiroSuda
AkihiroSuda requested changes Nov 29, 2019
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign with real name, then LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Nov 29, 2019

Looks like vndr also has to be run again to get the updated files;

[2019-11-29T10:37:43.517Z] The result of vndr differs
[2019-11-29T10:37:43.517Z] 
[2019-11-29T10:37:43.517Z]  M vendor/golang.org/x/sys/cpu/cpu_mips64x.go
[2019-11-29T10:37:43.517Z]  M vendor/golang.org/x/sys/cpu/cpu_mipsx.go
[2019-11-29T10:37:43.518Z]  M vendor/golang.org/x/sys/cpu/cpu_other_arm64.go
....

@XiaodongLoong
Copy link
Contributor Author

XiaodongLoong commented Dec 2, 2019

@AkihiroSuda
Nice to meet you. I am a Chinese people and family name is first named "Liu". My real name is Liu Xiaodong(刘 小东). So the sign is OK.
Thanks!

@XiaodongLoong
Copy link
Contributor Author

XiaodongLoong commented Dec 2, 2019

@thaJeztah How to run the "vndr" tool again, Can I excute the operation?

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Dec 2, 2019

"Signed-off-by: root" isn't correct

@thaJeztah thaJeztah mentioned this pull request Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda requested changes

Assignees

No one assigned

Labels

status/needs-vendoring status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XiaodongLoong @thaJeztah @AkihiroSuda