Disable integration/system tests that are failing on Windows with error "protocol not available" #40199
Merged
kolyshkin merged 1 commit intomoby:masterfrom Nov 26, 2019
Merged
Conversation
The tests starts a new daemon, but attempts to run it with overlay2, and using a unix:// socket, which doesn't really work on Windows. 40155 tried to disable such tests but missed two of them. They are being disabled with this change. Signed-off-by: vikrambirsingh <[email protected]>
This was referenced Nov 11, 2019
thaJeztah
approved these changes
Nov 13, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
ping @kolyshkin ptal
Member
|
@tiborvass PTAL |
Member
|
ping @tiborvass @AkihiroSuda @cpuguy83 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests starts a new daemon, but attempts to run it with overlay2,
and using a unix:// socket, which doesn't really work on Windows.
#40155 tried to disable such tests but missed two of them.
They are being disabled with this change.
relates to #40156 "Integration: fix TestInfoDebug and other tests that spin up daemons for Windows"
Signed-off-by: vikrambirsingh [email protected]
- What I did
Disabled two tests that were supposed to have been disabled by #40155 but got missed out
- How I did it
Skipped tests if OS is Windows
- How to verify it
Checks will verify that there are no failures on RS5
- Description for the changelog
Skip all integration/system tests on Windows that are using unix:// socket
- A picture of a cute animal (not mandatory but encouraged)