Volume plugin tests [integration/plugin/volumes] should always be executed - checks for OS Type should happen within the test#40193
Conversation
Premature check for OS type means that the test will never even get to run on other OS types. This will cause it to be always flagged as a failure on such OS types. Signed-off-by: vikrambirsingh <[email protected]>
|
@thaJeztah - there are actually known failures here [the two test cases that are not fixed by https://github.com//pull/40155]. We are hitting the known issue here whereby Jenkins does not always mark the run as failed even when one or more tests fail. We should take #39998 in ASAP because at least it shows the checks as failed in such a case. |
|
Hey @vikramhh, can you please add some prefix to this PR (and maybe commit as well). The current subject ("Check for OS Type and skip within the test") looks way too generic. I suggest |
vikramhh
changed the title
vikramhh
changed the title
vikramhh
changed the title
|
@kolyshkin - thanks for the feedback. I have changed both the title and description accordingly. |
|
@vikramhh is this ready for review? If so, could you move it out of "draft" mode? |
|
ping @cpuguy83 @AkihiroSuda @tiborvass PTAL |
4 participants
The current check for OS type in integration/plugin/volumes is premature. The test will never even get to run on "disallowed" OS types. No result [PASS/FAIL/SKIP] will be shown in the output. With certain tools like go testsum, the test will always flagged as a failure on such OS types.
This can be fixed by removing the check in places before the actual test.
Signed-off-by: vikrambirsingh [email protected]
- What I did
Removed OS Type check from a test in the main function
- How I did it
- How to verify it
Running the test on all OS Types should produce result [PASS/FAIL/SKIP]
- Description for the changelog
Removed a premature check for OSType to check if the test should be skipped.
- A picture of a cute animal (not mandatory but encouraged)