Jenkinsfile: set repo and branch for DCO check as well#40119
Merged
tiborvass merged 1 commit intomoby:masterfrom Oct 21, 2019
Merged
Jenkinsfile: set repo and branch for DCO check as well#40119tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/testing
process/cherry-pick
kind/bugfix
Member
Author
|
ping @tiborvass @kolyshkin @andrewhsu ptal |
This was referenced Oct 21, 2019
Merged
thaJeztah
commented
Oct 21, 2019
Jenkinsfile
Outdated
Member
Author
There was a problem hiding this comment.
guess for our private repositories, I need to add openssh-client here
Commit 7019b60 added these env-vars to other stages, but forgot to update the DCO stage, which also does a diff to validate commits that are in a PR. Also adding openssh-client, for situations where the upstream needs to be accessed through an ssh connection. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_dco_branch
branch
from
1680ff0 to
7c5fd83
Compare
tiborvass
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 7019b60 (#40035) added these
env-vars to other stages, but forgot to update the DCO stage,
which also does a diff to validate commits that are in a PR.
this should fix the issue we're seeing in docker-archive#408 (comment)