Conversation
|
Thank you for your contribution. I've just checked and your Pull Request doesn't appear to have any description. |
5e61514 to
8100969
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Left some suggestions/questions, but overall looks good
|
@AkihiroSuda do any of these changes require current "master"? Or should I cherry-pick this into the 19.03 release branch? |
8100969 to
fd5aefc
Compare
thanks, it would be better probably |
fd5aefc to
135130c
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! This reads much better!
LGTM
docs/rootless.md
Outdated
There was a problem hiding this comment.
Oh! This reminds me; I know people ran into problems running docker on Fedora 31; perhaps we should add this to the docs and release notes 👍 I'll have a look at creating PR's for that
docs/rootless.md
Outdated
There was a problem hiding this comment.
Should we update the dockerd-rootless.sh script to always add --experimental ? (if needed, we can make it print some warnings that rootless is still experimental)
There was a problem hiding this comment.
I think we intentionally omitted that for keeping the script simple.
Users don't need to care in most cases, because the installer script creates the systemd unit file with --experimental
docs/rootless.md
Outdated
There was a problem hiding this comment.
🤔 we could create a script that directly calls the API, and disables mount masks.
Could actually be a CLI plugin 🤔🤔
There was a problem hiding this comment.
we already have --security-opt systempaths=unconfined, but seems not enough
$ docker run --rm --security-opt seccomp=unconfined --security-opt apparmor=unconfined --security-opt systempataths=unconfined --cap-add all docker:19.03.3-dind-rootless --experimental
...
mount: permission denied (are you root?)
time="2019-10-13T11:15:55Z" level=warning msg="failed to mount sysfs ([[mount -t sysfs none /sys]]), falling back to read-only mount ([[mount -t sysfs -o ro none /sys]]): exit status 1"
open: No such file or directory
[rootlesskit:child ] error: executing [[ip tuntap add name tap0 mode tap] [ip link set tap0 address 02:50:00:00:00:01]]: exit status 1
Signed-off-by: Akihiro Suda <[email protected]>
135130c to
e76dea1
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM looks even better now 👌👍
|
@tonistiigi @tiborvass @tianon PTAL? |
|
|
||
| ```console | ||
| $ sudo sh -c "echo 0 2147483647 > /proc/sys/net/ipv4/ping_group_range" | ||
| $ sudo setcap cap_net_bind_service=ep $HOME/bin/rootlesskit |
There was a problem hiding this comment.
setcap may not installed on all systems per default. You can do this conditionally by something like:
sudo if command -v setcap > /dev/null && sudo setcap cap_net_bind_service=ep $HOME/bin/rootlesskit
There was a problem hiding this comment.
Anyway ... if the rootlesskit gets redeployed, the capabilities needs to be also set again. So using sysctl is the permanent way, but also less secure.
Uh oh!
There was an error while loading. Please reload this page.