integration-cli: Fix SA1019: httputil.ClientConn is deprecated#40074
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Dec 18, 2019
Merged
integration-cli: Fix SA1019: httputil.ClientConn is deprecated#40074AkihiroSuda merged 1 commit intomoby:masterfrom
SA1019: httputil.ClientConn is deprecated#40074AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
Member
|
Thanks! Looks like CI is failing on a linting issue; |
yedamao
force-pushed
the
fix-integration-cli
branch
from
0a5ccab to
5c2d1f8
Compare
Contributor
Author
|
@thaJeztah PTAL. Thanks. |
Contributor
|
@yedamao needs a rebase to address conflicts |
yedamao
force-pushed
the
fix-integration-cli
branch
from
5c2d1f8 to
00cd06c
Compare
Contributor
Author
|
@andrewhsu thanks. rebased and fixed conflicts |
cpuguy83
requested changes
Oct 18, 2019
yedamao
force-pushed
the
fix-integration-cli
branch
from
00cd06c to
0dc82e7
Compare
Rewrite sockRequestHijack to requestHijack which use writable Transport's Response.Body to replace deprecated hijacked httputil.ClientConn. ``` // As of Go 1.12, the Body will also implement io.Writer // on a successful "101 Switching Protocols" response, // as used by WebSockets and HTTP/2's "h2c" mode. Body io.ReadCloser ```. TestPostContainersAttach and TestExecResizeImmediatelyAfterExecStart replace all sockRequestHijack to requestHijack. Signed-off-by: HuanHuan Ye <[email protected]>
yedamao
force-pushed
the
fix-integration-cli
branch
from
0dc82e7 to
203ba72
Compare
Contributor
Author
|
@cpuguy83 PTAL |
AkihiroSuda
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite sockRequestHijack to requestHijack which use writable Response.Body
TestPostContainersAttach and TestExecResizeImmediatelyAfterExecStart
replace all sockRequestHijack to requestHijack.
Signed-off-by: HuanHuan Ye [email protected]
fixes #39927
- What I did
Fix
SA1019: httputil.ClientConn is deprecated- How I did it
Rewrite sockRequestHijack to requestHijack which use writable Response.Body
golang/go#28030 (comment)
- How to verify it
Maybe in CI golangci-lint
- Description for the changelog
integration-cli: Fix
SA1019: httputil.ClientConn is deprecated- A picture of a cute animal (not mandatory but encouraged)
