Failing, looks like you're referencing a wrong commit;

error: pathspec '5793aa66d4b4112c2602c716516e24710e4adbb5 # golang-1.13-fix in kolyshkin/go-swagger' did not match any file(s) known to git.

error: pathspec '5793aa66d4b4112c2602c716516e24710e4adbb5 # golang-1.13-fix in kolyshkin/go-swagger' did not match any file(s) known to git.

It's just I added a comment to an inappropriate place. Removed.

ah, lol you just pushed again

OK looks like it works:

[2019-10-04T23:46:23.571Z] The swagger spec at "api/swagger.yaml" is valid against swagger specification 2.0

Now I'm not sure what would be the best way to have it. Temporary, we can merge this one as-is (removing the second commit of course). Longer-term, IDK.

Now I'm not sure what would be the best way to have it. Temporary, we can merge this one as-is (removing the second commit of course). Longer-term, IDK.

Some thoughts;

• we don't (currently) need the new features of newer go-swagger versions, so it should be ok to keep using this old version for now
• this tool is only used locally, so if future Go updates break it again, perhaps we could consider pinning it to a fixed version of go (and/or pre-building the binaries)
  • decide if we want to fix the parts they removed in go-swagger again (see Fix skip flags go-swagger/go-swagger#691 for the last time it was fixed), or:
  • if we want to continue the work on Replace go-swagger with swagger-gen #36714, and replace it with https://github.com/dnephin/swagger-gen-types (I just noticed that that repository doesn't have a license, so we should make sure it has one if we want to switch)

OK here's my plan

1. merge this one as a temp fix to unblock CI
2. Try making upstream go-swagger work for us
3. If the above fails (I don't want to spend too much time on it), move the fork under moby and use it.

Rebased, added TODO

Weird; CI Hung after tests completed; https://ci.docker.com/public/job/moby/job/PR-40038/6/execution/node/195/log/?consoleFull

00:55:32.976  DONE 270 tests, 6 skipped in 2585.326s

...


02:00:04.686  Sending interrupt signal to process
02:00:04.715  Sending interrupt signal to process
02:00:13.230  /home/ubuntu/workspace/moby_PR-40038@tmp/durable-89316c98/script.sh: line 5:  9079 Terminated              docker run $rm -t --privileged -v "$WORKSPACE/bundles/${TEST_INTEGRATION_DEST}:/go/src/github.com/docker/docker/bundles" -v "$WORKSPACE/bundles/dynbinary-daemon:/go/src/github.com/docker/docker/bundles/dynbinary-daemon" -v "$WORKSPACE/.git:/go/src/github.com/docker/docker/.git" --name "$CONTAINER_NAME" -e KEEPBUNDLE=1 -e TESTDEBUG -e TESTFLAGS -e TEST_SKIP_INTEGRATION -e TEST_SKIP_INTEGRATION_CLI -e DOCKER_GITCOMMIT=${GIT_COMMIT} -e DOCKER_GRAPHDRIVER -e TIMEOUT -e VALIDATE_REPO=${GIT_URL} -e VALIDATE_BRANCH=${CHANGE_TARGET} docker:${GIT_COMMIT} hack/make.sh "$1" test-integration
02:00:13.230  Remaining pids to kill: []
02:00:13.235  script returned exit code 143