Conversation
Pull requests started failing because vendoring didn't match; ``` The result of vndr differs D vendor/golang.org/x/sync/singleflight/singleflight.go Please vendor your package with github.com/LK4D4/vndr. ``` Signed-off-by: Sebastiaan van Stijn <[email protected]>
cpuguy83
left a comment
cpuguy83
left a comment
There was a problem hiding this comment.
LGTM assuming CI is happy.
Do we know what happened?
|
No, I just found out that the problem was on master (see #40032 (comment)), I initially thought it was something weird with Likely a PR got merged out of order, or perhaps got merged on "red" I'd like to find the PR though (in case it's one that we have to backport, so that we can cherry-pick them together) |
|
Ah! I understand why; this is from that PR: The vendor check only runs if |
perhaps we should have a check if imports are added/removed (but that might be overhead); this likely is a bit of a corner case (last import of a package removed), so perhaps we should just take it for granted |
|
Vendor check passed now:
|
5 participants
relates to #39966 (comment), #40032 (comment), #39713 (comment)
Pull requests started failing because vendoring didn't match;