integration-cli: prevent out of range in TestEventsContainerEvents#40026
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 3, 2019
Merged
Conversation
Member
Author
|
actually, perhaps I can do slightly better |
044b860 to
a78c6b6
Compare
Prevents the test from panicking;
```
--- FAIL: TestDockerSuite/TestEventsContainerEvents (1.19s)
suite.go:65: test suite panicked: runtime error: slice bounds out of range [:5] with capacity 4
goroutine 3978 [running]:
runtime/debug.Stack(0xc0026e3908, 0x1ad9bc0, 0xc0008100c0)
/usr/local/go/src/runtime/debug/stack.go:24 +0x9d
github.com/docker/docker/internal/test/suite.failOnPanic(0xc00185e600)
/go/src/github.com/docker/docker/internal/test/suite/suite.go:65 +0x57
panic(0x1ad9bc0, 0xc0008100c0)
/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/docker/docker/integration-cli.(*DockerSuite).TestEventsContainerEvents(0x2f7d7a8, 0xc00185e600)
/go/src/github.com/docker/docker/integration-cli/docker_cli_events_test.go:89 +0x3c5
reflect.Value.call(0xc0000c4f00, 0xc0008036c0, 0x13, 0x1bfd18b, 0x4, 0xc000e8df30, 0x2, 0x2, 0xc00075c618, 0x40d903, ...)
/usr/local/go/src/reflect/value.go:460 +0x5f6
reflect.Value.Call(0xc0000c4f00, 0xc0008036c0, 0x13, 0xc00075c730, 0x2, 0x2, 0xf, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:321 +0xb4
github.com/docker/docker/internal/test/suite.Run.func2(0xc00185e600)
/go/src/github.com/docker/docker/internal/test/suite/suite.go:57 +0x2c2
testing.tRunner(0xc00185e600, 0xc0008dbea0)
/usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:960 +0x350
```
Signed-off-by: Sebastiaan van Stijn <[email protected]>
a78c6b6 to
97aa82d
Compare
tiborvass
approved these changes
Oct 3, 2019
arkodg
approved these changes
Oct 3, 2019
Member
Author
|
merging this as this may help investigating why #39966 fails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the test from panicking;
Signed-off-by: Sebastiaan van Stijn [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)