Skip to content

integration-cli: fix DockerNetworkSuite not being run#40016

Merged
kolyshkin merged 1 commit intomoby:masterfrom
thaJeztah:fix_dockernetworksuite
Sep 30, 2019
Merged

integration-cli: fix DockerNetworkSuite not being run#40016
kolyshkin merged 1 commit intomoby:masterfrom
thaJeztah:fix_dockernetworksuite

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 30, 2019 •
edited
Loading

fixes #40010

noticed this in #40010, where it was reported that (e.g.) TestDockerNetworkSuite/TestExternalVolumeDriverBindExternalVolume was failing, but that test should not be part of TestDockerNetworkSuite. Then I noticed that the actual network tests (e.g. TestDockerNetworkLsDefault) were not running 🙀 😅

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2019

ping @tiborvass @andrewhsu @kolyshkin PTAL

This was referenced Sep 30, 2019
Closed
Closed
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2019

Tests are now run, and Volume tests are shown under the correct suite;

00:44:26.658  === RUN   TestDockerExternalVolumeSuite
00:44:26.658  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverBindExternalVolume
00:44:41.598  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverCapabilities
00:45:49.180  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverDeleteContainer
00:45:59.143  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverGet
00:46:31.221  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverGetEmptyResponse
00:46:44.517  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverList
00:47:16.550  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverLookupNotBlocked
00:47:31.363  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverMountID
00:48:03.353  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverNamed
00:48:18.251  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverOutOfBandDelete
00:48:36.268  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverPathCalls
00:49:22.941  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverRetryNotImmediatelyExists
00:49:40.955  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverUnmountOnCp
00:50:12.947  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverUnmountOnMountFail
00:50:44.981  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverUnnamed
00:50:59.887  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverVolumesFrom
00:51:17.903  === RUN   TestDockerExternalVolumeSuite/TestExternalVolumeDriverWithDaemonRestart
00:51:32.717  === RUN   TestDockerExternalVolumeSuite/TestVolumeCLICreateOptionConflict
00:51:47.571  --- PASS: TestDockerExternalVolumeSuite (442.00s)

...

00:41:43.122  === RUN   TestDockerNetworkSuite
00:41:43.122  === RUN   TestDockerNetworkSuite/TestConntrackFlowsLeak
00:41:46.465  === RUN   TestDockerNetworkSuite/TestDeprecatedDockerNetworkStartAPIWithHostconfig
00:41:47.557  === RUN   TestDockerNetworkSuite/TestDockerNetworkAnonymousEndpoint
00:41:53.000  === RUN   TestDockerSwarmSuite/TestSwarmRotateUnlockKey
...

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2019

docker-py failure should be unrelated; https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-40016/runs/1/nodes/221/log/?start=0


[2019-09-30T14:12:01.998Z] =================================== FAILURES ===================================
[2019-09-30T14:12:01.998Z] __________________________ SwarmTest.test_update_node __________________________
[2019-09-30T14:12:01.998Z] docker/api/client.py:261: in _raise_for_status
[2019-09-30T14:12:01.998Z]     response.raise_for_status()
[2019-09-30T14:12:01.998Z] /usr/local/lib/python3.6/site-packages/requests/models.py:940: in raise_for_status
[2019-09-30T14:12:01.998Z]     raise HTTPError(http_error_msg, response=self)
[2019-09-30T14:12:01.998Z] E   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http+docker://localhost/v1.35/swarm/init
[2019-09-30T14:12:01.998Z] 
[2019-09-30T14:12:01.998Z] During handling of the above exception, another exception occurred:
[2019-09-30T14:12:01.998Z] tests/integration/api_swarm_test.py:201: in test_update_node
[2019-09-30T14:12:01.998Z]     assert self.init_swarm()
[2019-09-30T14:12:01.998Z] tests/integration/base.py:127: in init_swarm
[2019-09-30T14:12:01.998Z]     return self._init_swarm(self.client, **kwargs)
[2019-09-30T14:12:01.998Z] tests/integration/base.py:94: in _init_swarm
[2019-09-30T14:12:01.998Z]     '127.0.0.1', listen_addr=helpers.swarm_listen_addr(), **kwargs
[2019-09-30T14:12:01.998Z] docker/utils/decorators.py:34: in wrapper
[2019-09-30T14:12:01.998Z]     return f(self, *args, **kwargs)
[2019-09-30T14:12:01.998Z] docker/api/swarm.py:170: in init_swarm
[2019-09-30T14:12:01.998Z]     return self._result(response, json=True)
[2019-09-30T14:12:01.998Z] docker/api/client.py:267: in _result
[2019-09-30T14:12:01.998Z]     self._raise_for_status(response)
[2019-09-30T14:12:01.998Z] docker/api/client.py:263: in _raise_for_status
[2019-09-30T14:12:01.998Z]     raise create_api_error_from_http_exception(e)
[2019-09-30T14:12:01.998Z] docker/errors.py:31: in create_api_error_from_http_exception
[2019-09-30T14:12:01.998Z]     raise cls(e, response=response, explanation=explanation)
[2019-09-30T14:12:01.998Z] E   docker.errors.APIError: 500 Server Error: Internal Server Error ("manager stopped: can't initialize raft node: failed to open WAL: fileutil: file already locked")

I'll kick CI once more

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2019

#40015 was rebased on top of this one, and is green, so definitely should not be related

andrewhsu
andrewhsu approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i trust that #40015 green is the path to non-red

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 30, 2019

it's green!

tiborvass
tiborvass approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG :S

kolyshkin
kolyshkin approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit 09ee529 into moby:master Sep 30, 2019
@thaJeztah thaJeztah deleted the fix_dockernetworksuite branch September 30, 2019 17:54
This was referenced Sep 30, 2019
Closed
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiborvass tiborvass tiborvass approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

+1 more reviewer

@andrewhsu andrewhsu andrewhsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

integration-cli failures in TestDockerNetworkSuite on s390x and ppc64le

4 participants

@thaJeztah @andrewhsu @tiborvass @kolyshkin