Skip to content

Comments

Windows: skip flaky TestLogBlocking#39887

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:skip_flaky_TestLogBlocking
Sep 10, 2019
Merged

Windows: skip flaky TestLogBlocking#39887
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:skip_flaky_TestLogBlocking

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Sep 9, 2019

This test frequently fails on Windows RS1 (mainly), so skipping it for now on Windows. There's a tracking issue for fixing the tests in #39857

ok  	github.com/docker/docker/daemon/logger	0.525s	coverage: 43.0% of statements
time="2019-09-09T20:37:35Z" level=info msg="Trying to get region from EC2 Metadata"
time="2019-09-09T20:37:36Z" level=info msg="Log stream already exists" errorCode=ResourceAlreadyExistsException logGroupName= logStreamName= message= origError="<nil>"
--- FAIL: TestLogBlocking (0.02s)
    cloudwatchlogs_test.go:313: Expected to be able to read from stream.messages but was unable to
time="2019-09-09T20:37:36Z" level=error msg=Error
time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=InvalidSequenceTokenException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>"
time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>"
time="2019-09-09T20:37:36Z" level=info msg="Data already accepted, ignoring error" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token"
FAIL
coverage: 78.2% of statements
FAIL	github.com/docker/docker/daemon/logger/awslogs	0.630s

@thaJeztah
Windows: skip flaky TestLogBlocking
6c75c86 
This test frequently fails on Windows RS1 (mainly), so skipping it
for now on Windows;

```
ok  	github.com/docker/docker/daemon/logger	0.525s	coverage: 43.0% of statements
time="2019-09-09T20:37:35Z" level=info msg="Trying to get region from EC2 Metadata"
time="2019-09-09T20:37:36Z" level=info msg="Log stream already exists" errorCode=ResourceAlreadyExistsException logGroupName= logStreamName= message= origError="<nil>"
--- FAIL: TestLogBlocking (0.02s)
    cloudwatchlogs_test.go:313: Expected to be able to read from stream.messages but was unable to
time="2019-09-09T20:37:36Z" level=error msg=Error
time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=InvalidSequenceTokenException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>"
time="2019-09-09T20:37:36Z" level=error msg="Failed to put log events" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token" origError="<nil>"
time="2019-09-09T20:37:36Z" level=info msg="Data already accepted, ignoring error" errorCode=DataAlreadyAcceptedException logGroupName=groupName logStreamName=streamName message="use token token"
FAIL
coverage: 78.2% of statements
FAIL	github.com/docker/docker/daemon/logger/awslogs	0.630s
```

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 10, 2019

And, of course, Windows RS1 fails on another flaky test;

https://ci.docker.com/public/job/moby/job/PR-39887/1/execution/node/199/log/?consoleFull

 ----------------------------------------------------------------------
 FAIL: docker_cli_ps_test.go:439: DockerSuite.TestPsListContainersFilterExited
 
 docker_cli_ps_test.go:456:
     c.Assert(out, checker.Contains, strings.TrimSpace(secondZero))
 ... obtained string = "" +
 ...     "3a85c1209a90eda4cb8243c39878a10b53dae1d5f3604f20aba307f0873ba7e0\n" +
 ...     "6fbf6ffaaec451629be853f191a1c1ddb89c43d1464de147eeaa848554816f1b\n"
 ... substring string = "eae41c1f07c3e1c1d6d719cf55b22d074c4b7504ab134fec580b4d25a7fa66dd"

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 10, 2019

Interesting; I did improve that test a bit in the past (#39325), but apparently it still has issues

@bamarni
Copy link
Contributor

bamarni commented Sep 10, 2019

I'm also hitting this test failure in #39728, I re-triggered the build just in case but it failed twice in a row.

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 10, 2019

And LOL, now Windows RS5 is failing on that other flaky test; https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-39887/runs/1/nodes/50/log/?start=0

----------------------------------------------------------------------
FAIL: docker_cli_ps_test.go:439: DockerSuite.TestPsListContainersFilterExited

docker_cli_ps_test.go:456:
    c.Assert(out, checker.Contains, strings.TrimSpace(secondZero))
... obtained string = "" +
...     "3a85c1209a90eda4cb8243c39878a10b53dae1d5f3604f20aba307f0873ba7e0\n" +
...     "6fbf6ffaaec451629be853f191a1c1ddb89c43d1464de147eeaa848554816f1b\n"
... substring string = "eae41c1f07c3e1c1d6d719cf55b22d074c4b7504ab134fec580b4d25a7fa66dd"

@thaJeztah thaJeztah mentioned this pull request Sep 10, 2019
Open
kolyshkin
kolyshkin approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

thaJeztah commented Sep 10, 2019

I'm bringing this in to get CI in a slightly more acceptable state

@thaJeztah thaJeztah merged commit a3ca7b2 into moby:master Sep 10, 2019
@thaJeztah thaJeztah deleted the skip_flaky_TestLogBlocking branch September 10, 2019 19:19
This was referenced Sep 10, 2019
Merged
Merged
@bamarni bamarni mentioned this pull request Sep 17, 2019
Merged
@thaJeztah thaJeztah mentioned this pull request Sep 25, 2019
Merged
@thaJeztah thaJeztah mentioned this pull request Oct 8, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

Assignees

No one assigned

Labels

area/testing platform/windows process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @bamarni @kolyshkin @GordonTheTurtle