docker-py: skip flaky AttachContainerTest::test_attach_no_stream#39848
Merged
tiborvass merged 1 commit intomoby:masterfrom Sep 6, 2019
Merged
docker-py: skip flaky AttachContainerTest::test_attach_no_stream#39848tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
Seen failing a couple of times: ``` [2019-09-02T08:40:15.796Z] =================================== FAILURES =================================== [2019-09-02T08:40:15.796Z] __________________ AttachContainerTest.test_attach_no_stream ___________________ [2019-09-02T08:40:15.796Z] tests/integration/api_container_test.py:1250: in test_attach_no_stream [2019-09-02T08:40:15.796Z] assert output == 'hello\n'.encode(encoding='ascii') [2019-09-02T08:40:15.796Z] E AssertionError: assert b'' == b'hello\n' [2019-09-02T08:40:15.796Z] E Right contains more items, first extra item: 104 [2019-09-02T08:40:15.796Z] E Use -v to get the full diff ``` Signed-off-by: Sebastiaan van Stijn <[email protected]>
tiborvass
approved these changes
Sep 6, 2019
This was referenced Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen failing a couple of times, e.g. #39842 (comment):
Perhaps this needs a change similar to docker/docker-py@ef04355 (docker/docker-py#2307)