-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Jenkinsfile: add stage for Windows 2022 (SAC) #39846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This might show the problem that's reported in docker/for-win#3884, which was indicated to be a regression in the platform; docker/for-win#3884 (comment)
But only shows on Docker Desktop (because Docker Enterprise is only supported on Windows Server LTS versions), and thus doesn't show up in current CI in this repository (which didn't test against 1903). Possibly skipping this step for Windows 1903 could work around the platform regression; moby/builder/dockerfile/internals.go Lines 458 to 465 in facad55
|
|
The good news; Windows 1903 machines are working, and CI starts; The "bad" news; the 1903 machines have Windows Defender enabled, which is currently preventing CI to run https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-39846/runs/1/nodes/240/log/?start=0 (until #39804 is merged, or the configuration of those machines is changed) |
|
@StefanScherer ^^ looks like we may want to update the configuration for those machines (or explicitly disable it through our Jenkinsfile?) |
kolyshkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
hack/ci/windows.ps1
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefanScherer this was just an attempt to see if this would help with the RS1 builds sometimes not exiting; not sure if this would help or not (happy to drop this commit if it doesn't make sense)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to a separate PR #39854
05f7df5 to
7f41764
Compare
|
Failure on RS5 is a flaky test: #36801 |
|
We might want to consider running this one in Hyper-V mode (which I think is where the linked issue occurs) |
|
Pushed a commit to run Windows 1903 with hyper-v isolation |
|
couple of failures now that I enabled hyper-v; https://ci.docker.com/public/job/moby/job/PR-39846/7/execution/node/197/log/?consoleFull Looks like this test should be either skipped on hyper-v, or modified; |
69ee038 to
aa04d99
Compare
|
With |
aa04d99 to
f3d6142
Compare
|
Added a commit to only set the size for build-containers to 127GB if no size was configured on the daemon. |
|
Aaaaand... unit tests failed on #39856 |
|
Ok, that last commit didn't help it seems; Can try disabling that line altogether (perhaps at that point the config isn't set) |
d105437 to
8dbfb92
Compare
Fixed; moved it to the win-2022 part, and (to test) reverted the last (skip tests) commit; I think it's good to have at least one of the Windows stages run with Hyper-V; that said, we discussed removing RS1 from the list at some point; perhaps we can add a "windows latest (Hyper-V)" and "windows latest (Process)". |
8dbfb92 to
d8f9340
Compare
|
Hmmm.... looks like running it on Hyper-V fails; getting some hcsshim failure |
|
@thaJeztah as those tests already passed without Hyper-V maybe it would be better to disable it again, squash commits and merge this one? I was hoping to be able use 2022 on #41479 (testing my proposal #41455 (comment)) but it looks to be still that Jenkinsfile changes does not take effect before merging to master.
Honestly I do not care about Hyper-V mode as we do not use it anywhere but sure because that feature exist then it probably should be part of tests. |
This adds a stage to test against the current SAC (Semi Annual Channel), which allows us to catch possible regressions on upcoming LTS versions. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Images for Windows 2022 (SAC) are not yet available, so using insider builds in the meantime; mcr.microsoft.com/windows/servercore/insider:10.0.20295.1 Signed-off-by: Sebastiaan van Stijn <[email protected]>
d8f9340 to
b5f0096
Compare
|
Removed the commits that (I think) were all Hyper-V related; these commits were removed:
I kept those in a separate branch, so if some need to be added back I can add them; let's see what CI says |
|
Pushed the other branch as draft #42277 |
|
@thaJeztah looks that you skipped one change too much. We need 48d0152 here. |
Ah! That was the one I wasn't sure about (didn't recall if it was version only, or hyper-v specific); will fix |
These tests fail, possibly due to changes in the kernel. Temporarily skipping
these tests, so that we at least have some coverage on these windows versions
in this repo, and we can look into this specific issue separately.;
=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s)
changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}]
=== FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s)
changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew"
Signed-off-by: Sebastiaan van Stijn <[email protected]>
c547624 to
8f4b3b0
Compare
olljanat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
StefanScherer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM !
|
Thanks! I'll go ahead and merge 🤗 |
This adds a stage to test against the current SAC (Semi Annual Channel),
which allows us to catch possible regressions on upcoming LTS versions.
addresses ENGCORE-832