pkg/term: refactor TestEscapeProxyRead#39800
Merged
tiborvass merged 1 commit intomoby:masterfrom Sep 6, 2019
Merged
Conversation
- use subtests to make it clearer what the individual test-cases are, and to prevent tests from depending on values set by the previous test(s). - remove redundant messages in assert (gotest.tools already prints a useful message if assertions fail). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/testing
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
Member
Author
Windows RS5: This one may be racy; https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-39800/runs/1/nodes/192/log/?start=0 |
Member
Author
|
ping @kolyshkin @vdemeester PTAL 🤗 |
vdemeester
reviewed
Aug 28, 2019
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
@thaJeztah Nice ! 😉 we may even be able to use test tables to reduce a bit the duplication of code
Member
Author
that's what I tried at the start, but although they look very similar, there's quite some subtle differences between the tests, and writing a table for that resulted in a lot of |
bamarni
reviewed
Sep 2, 2019
| assert.DeepEqual(t, keys, buf) | ||
| }) | ||
|
|
||
| t.Run("ctrl-c,ctrl-z escape key, keys ctrl-c,ctrl-z", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
nit: in the test name I would use the ctrl-c,ctrl-z escape key, keys [ctrl-c],[ctrl-z] format, because the sequence of reads matters, for example on my PR I have a test for [ctrl-c,ctrl-z] (a single read with 2 bytes), which doesn't work with the current code.
I can as well change the format on my PR when I rebase.
Member
Author
There was a problem hiding this comment.
Ah, good suggestion; yes, perhaps ok to touch-up those as part of your PR
Member
Author
|
@kolyshkin @vdemeester LGTY? |
tiborvass
approved these changes
Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed this test while reviewing #39728, and did some refactoring
are, and to prevent tests from depending on values set by the
previous test(s).
a useful message if assertions fail).