-
Notifications
You must be signed in to change notification settings - Fork 18.9k
[RFC] Jenkinsfile: reduce duplicated code by defining some functions #39708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
ok, first attempt didn't work |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
| @@ -1,4 +1,45 @@ | |||
| #!groovy | |||
|
|
|||
| void printInfo() { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to move this to a separate file (which might be possible, but let's discuss first if we like the approach)
|
@andrewhsu @tiborvass wdyt of an approach like this? |
|
@thaJeztah I think that I would not oppose this, but I would much rather go away from Jenkinsfile as much as possible, so that we can simply call make targets instead, the same ones that would be called in CI from Jenkinsfile. |
|
@tiborvass agreed; we should try to move things to the makefile as much as possible. Not sure how we'll deal with Windows (without having There might still be CI-specific steps (not sure if we want those in the makefile) I can close this one for now, as it was mainly a PoC / quick attempt |
|
@thaJeztah we could either leverage bash on windows, or start converting bash to Go. |
|
(not related to testing, but also thinking how important it is to support build everything outside of a container, or if we can start inlining things in the dockerfile) |
not sure if this works, but an attempt at reducing a lot of duplication in our Jenkinsfile