Skip to content

Conversation

@thaJeztah
Copy link
Member

not sure if this works, but an attempt at reducing a lot of duplication in our Jenkinsfile

@thaJeztah
Copy link
Member Author

ok, first attempt didn't work

WorkflowScript: 145: Method calls on objects not allowed outside "script" blocks. @ line 145, column 33.
                                   utils.buildDevImage()
                                   ^

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@@ -1,4 +1,45 @@
#!groovy

void printInfo() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to move this to a separate file (which might be possible, but let's discuss first if we like the approach)

@thaJeztah
Copy link
Member Author

@andrewhsu @tiborvass wdyt of an approach like this?

@tiborvass
Copy link
Contributor

@thaJeztah I think that I would not oppose this, but I would much rather go away from Jenkinsfile as much as possible, so that we can simply call make targets instead, the same ones that would be called in CI from Jenkinsfile.

@thaJeztah
Copy link
Member Author

@tiborvass agreed; we should try to move things to the makefile as much as possible. Not sure how we'll deal with Windows (without having make there; I think there's some "make-like" tools though).

There might still be CI-specific steps (not sure if we want those in the makefile)

I can close this one for now, as it was mainly a PoC / quick attempt

@thaJeztah thaJeztah closed this Sep 30, 2019
@tiborvass
Copy link
Contributor

@thaJeztah we could either leverage bash on windows, or start converting bash to Go.

@thaJeztah
Copy link
Member Author

(not related to testing, but also thinking how important it is to support build everything outside of a container, or if we can start inlining things in the dockerfile)

@thaJeztah thaJeztah deleted the jenkinsfile_dry branch April 28, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants