Use more functionality from golang.org/x/sys/unix#39707
Merged
tiborvass merged 3 commits intomoby:masterfrom Aug 23, 2019
Merged
Use more functionality from golang.org/x/sys/unix#39707tiborvass merged 3 commits intomoby:masterfrom
tiborvass merged 3 commits intomoby:masterfrom
Conversation
Member
|
😍 thanks! |
Member
|
@kolyshkin ptal |
Member
|
@tonistiigi @kolyshkin ptal |
Member
|
vendoring was updated in #39726, which should have all the changes needed for this PR, so the vendor bump can be dropped here |
…pback without cgo Signed-off-by: Tobias Klauser <[email protected]>
This allows to merge the implementation for Linux and FreeBSD. Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
more-x-sys-unix
branch
from
36e7c4e to
2841b05
Compare
Contributor
Author
|
@tonistiigi @thaJeztah Thanks! Rebased and dropped the vendoring changes. |
Member
|
Thanks! Hm.. interesting; we enabled the new
^^ @tiborvass |
tonistiigi
approved these changes
Aug 23, 2019
tiborvass
reviewed
Aug 23, 2019
| if err != nil { | ||
| return err | ||
| uts := []unix.Timespec{ | ||
| unix.NsecToTimespec(syscall.TimespecToNsec(ts[0])), |
Contributor
There was a problem hiding this comment.
might as well change LUtimesNano callers to send a []unix.Timespec instead. Can be done in a followup.
Contributor
Author
There was a problem hiding this comment.
Thanks, will send a followup PR.
tiborvass
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Updated the vendored copy of the
golang.org/x/syspackage. Changedpkg/loopback,pkg/systemandpkg/dmesg? to use functions, types and constants fromgolang.org/x/sys/unix` instead of duplicating them.- How I did it
Replaced manual re-implementations of said functions, types and constants with equivalent counterparts provided by
golang.org/x/sys/unix.- How to verify it
Compare current implementation to respective counterparts in
x/sys/unix.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)