daemon.initCgroupsPath fix unhandled error in recursion#39704
Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
Closed
daemon.initCgroupsPath fix unhandled error in recursion#39704thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
This was added in 56f77d5, but I don't see a mention of errors being deliberately ignored here, so this might just have been missed during review Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@kolyshkin @crosbymichael ptal |
tiborvass
reviewed
Aug 19, 2019
| // for the period and runtime as this limits what the children can be set to. | ||
| daemon.initCgroupsPath(filepath.Dir(path)) | ||
| if err := daemon.initCgroupsPath(filepath.Dir(path)); err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
if not here, then in initCgroupsPath
Member
Author
There was a problem hiding this comment.
This is initCgroupsPath; it's recursing. The final error is "wrapped" (well, fmt.Errorf - we should change that) here;
Lines 793 to 795 in 3042254
Contributor
There was a problem hiding this comment.
I'm talking about package boundaries like lines 1564, 1583 and 1586
Member
|
ping @thaJeztah |
Contributor
|
should be obsoleted by #41016 (which was updated after reading review comments above) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in 56f77d5 (#23430), but I don't see a mention of errors being deliberately ignored here, so this might just have been missed during review