added entry for running unit tests with junit report#39638
added entry for running unit tests with junit report#39638vdemeester merged 1 commit intomoby:masterfrom
Conversation
There was a problem hiding this comment.
Are there advantages to using this instead of gotestsum? docker/cli#1639
There was a problem hiding this comment.
i'll have a look. i started with go-junit-report because that's what i've used in the past and was easiest to setup.
There was a problem hiding this comment.
i decided to use gotestsum after getting to know it because it's better
849a6f6 to
927ea39
Compare
7e989e3 to
8954289
Compare
|
ping @vdemeester ptal |
|
interesting failure on janky |
|
@thaJeztah i needed to introduce a failure to see how junit failure reporting looks: https://ci.docker.com/public/job/moby/job/PR-39638/9/testReport/github/com_docker_docker_pkg_pubsub/TestSendToOneSub/ |
Signed-off-by: Andrew Hsu <[email protected]>
|
I think this is ready for merge. This PR adds another parallel PR check stage in the The contents of the bundle are:
The The graphs and tables will help developers quickly locate the info of the failing unit tests instead of searching for the error on the verbose console output page of the jenkins job. To accomplish this, I had to add gotestsum to the |
|
|
|
PTAL @thaJeztah @vdemeester |
|
LGTM |
Signed-off-by: Andrew Hsu [email protected]
(cherry picked from commit 30d1bf8)
Signed-off-by: Tibor Vass [email protected]
#39637