Fix TestSwarmClusterRotateUnlockKey #39616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
area/testing
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
thaJeztah
approved these changes
Jul 26, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
heh 😂 that was the issue all this time? LGTM
tiborvass
approved these changes
Jul 26, 2019
Member
@thaJeztah No, this retry for allowing this error (that shouldn't really be allowed to happen) was added last week @dperny There's an identical check in TestSwarmRotateUnlockKey |
Member
Contributor
Member
|
Is it worth logging the first 5 attempts if we know converging takes some time? (it already logs a failure if 5 attempts failed) |
TestSwarmClusterRotateUnlockKey had been identified as a flaky test. It turns out that the test code was wrong: where we should have been checking the string output of a command, we were instead checking the value of the error. This means that the error case we were expecting was not being matched, and the test was failing when it should have just retried. Signed-off-by: Drew Erny <[email protected]>
dperny
force-pushed
the
fix-cluster-rotate-unlock-key
branch
from
db55ead to
b79adac
Compare
Contributor
Author
|
Fixed the other test in the same way. |
tonistiigi
approved these changes
Jul 26, 2019
This was referenced Sep 1, 2019
Member
|
Looks like this test is still flaky #39883 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSwarmClusterRotateUnlockKey had been identified as a flaky test. It turns out that the test code was wrong: where we should have been checking the string output of a command, we were instead checking the value of the error. This means that the error case we were expecting was not being matched, and the test was failing when it should have just retried.