Skip to content

DockerSwarmSuite lock portIndex to work around race#39516

Merged
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:lock_portindex
Jul 13, 2019
Merged

DockerSwarmSuite lock portIndex to work around race#39516
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:lock_portindex

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jul 13, 2019

@thaJeztah thaJeztah mentioned this pull request Jul 13, 2019
Open
cpuguy83
cpuguy83 approved these changes Jul 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jul 13, 2019

Maybe not related to the comment (I think memberlist is different), but seems like it should be locked anyway b/c everything else is.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@47a84dc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39516   +/-   ##
=========================================
  Coverage          ?   37.29%           
=========================================
  Files             ?      609           
  Lines             ?    45228           
  Branches          ?        0           
=========================================
  Hits              ?    16870           
  Misses            ?    26067           
  Partials          ?     2291

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 13, 2019

rebased to get the latest fixes in

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 13, 2019

Failure on Windows RS1; haven't seen that one, but could be an issue with the machine being slow?

https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/25858/console

11:30:09 --- FAIL: TestCopierSlow (0.36s)
11:30:09     copier_test.go:221: failed to exit in time after the copier is closed
11:30:09 FAIL
11:30:09 coverage: 43.0% of statements

yongtang
yongtang approved these changes Jul 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongtang yongtang merged commit b3a48b7 into moby:master Jul 13, 2019
@thaJeztah thaJeztah deleted the lock_portindex branch July 14, 2019 00:01
@thaJeztah thaJeztah mentioned this pull request Sep 25, 2019
Merged
@thaJeztah thaJeztah mentioned this pull request Oct 8, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
@thaJeztah thaJeztah mentioned this pull request Jun 8, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

+1 more reviewer

@yongtang yongtang yongtang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @cpuguy83 @yongtang @GordonTheTurtle