Skip to content

bump gorilla/mux v1.7.2#39381

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:bump_gorilla_mux
Jun 26, 2019
Merged

bump gorilla/mux v1.7.2#39381
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:bump_gorilla_mux

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 20, 2019

engine equivalent of docker/cli#1958

full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

@thaJeztah
bump gorilla/mux v1.7.2
25b451e 
full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 21, 2019

Janky failing on DockerSwarmSuite.TestSwarmClusterRotateUnlockKey, which is a known flaky, and tracked through #38885 and #33041 / #37306

13:05:39 docker_cli_swarm_test.go:1387:
13:05:39     c.Assert(err, checker.IsNil, check.Commentf("%s", outs))
13:05:39 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc0052fb240), Stderr:[]uint8(nil)} ("exit status 1")
13:05:39 ... Error response from daemon: rpc error: code = Unknown desc = The swarm does not have a leader. It's possible that too few managers are online. Make sure more than half of the managers are online.
13:05:39

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@384c782). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39381   +/-   ##
=========================================
  Coverage          ?   37.36%           
=========================================
  Files             ?      609           
  Lines             ?    45209           
  Branches          ?        0           
=========================================
  Hits              ?    16894           
  Misses            ?    26026           
  Partials          ?     2289

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 24, 2019

ping @vdemeester @kolyshkin ptal

vdemeester
vdemeester reviewed Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jun 26, 2019

ping @kolyshkin PTAL

vdemeester
vdemeester approved these changes Jun 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌞

cpuguy83
cpuguy83 approved these changes Jun 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit a50869f into moby:master Jun 26, 2019
@thaJeztah thaJeztah deleted the bump_gorilla_mux branch June 26, 2019 17:55
@thaJeztah thaJeztah mentioned this pull request Jun 26, 2019
Merged
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @vdemeester @cpuguy83 @GordonTheTurtle