ping @kolyshkin ptal

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "testForIpvlan" [email protected]:jim-docker/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842356984576
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Codecov Report

❗ No coverage uploaded for pull request base (master@fb5fe24). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #39358   +/-   ##
=========================================
  Coverage          ?      37%           
=========================================
  Files             ?      612           
  Lines             ?    45643           
  Branches          ?        0           
=========================================
  Hits              ?    16890           
  Misses            ?    26471           
  Partials          ?     2282

Two things

1. No need to check for the kernel version at all, as we already have a better check. Some distros might have backported this functionality to older kernel (and in general these days kernel version doesn't mean much so we only check it as a last resort, i.e. if we have no other way).

2. Please squash your commits, it's very hard to review it the way it is.

Two things

1. No need to check for the kernel version at all, as we already have a better check. Some distros might have backported this functionality to older kernel (and in general these days kernel version doesn't mean much so we only check it as a last resort, i.e. if we have no other way).
2. Please squash your commits, it's very hard to review it the way it is.

1. OK. I had the impression the problem was with the kernel < 4.2, even if ipvlan is enabled. If not I will remove the version check.

2. squashing now will make a mess of other reviews, no? Don't you just review the diff between my branch and moby master ("Changes from all commits")?

I had the impression the problem was with the kernel < 4.2, even if ipvlan is enabled. If not I will remove the version check.

Does not matter. We now have better check for the feature, and it's sufficient, so there's absolutely no reason to wrap it into another, much less reliable, check.

Don't you just review the diff

I can and I actually did, as per the comment about kernel version check above.

We still need to squash it anyway before merging, as it's one small logical change and it should be one commit -- otherwise we'll pollute git log

We still need to squash it anyway before merging, as it's one small logical change and it should be one commit -- otherwise we'll pollute git log

I'll squash it, but I recall seeing a checkbox you can select when merging to master to do the squash automatically

I'll squash it, but I recall seeing a checkbox you can select when merging to master to do the squash automatically

We tend not to use that option because;

• it modifies the contributor's commit
• commits that were GPG signed by the contributor no longer are signed
• commits can no longer traced back (or at least; no longer match) the commits in the pull request