allow dockerd builds without cgo#39327
Merged
cpuguy83 merged 3 commits intomoby:masterfrom Jun 7, 2019
Merged
Conversation
tiborvass
approved these changes
Jun 5, 2019
kolyshkin
requested changes
Jun 6, 2019
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
improve-non-cgo
branch
from
eef31a0 to
cf104d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #39327 +/- ##
=========================================
Coverage ? 37.05%
=========================================
Files ? 612
Lines ? 45522
Branches ? 0
=========================================
Hits ? 16867
Misses ? 26371
Partials ? 2284 |
Member
@kolyshkin we could update https://github.com/moby/moby/blob/master/project/PACKAGERS.md#docker_buildtags But in general we need to unify / cleanup project documentation |
justincormack
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches allow building usable dockerd without the need of cgo. No changes to the current default way how we produce binaries.
Changes are in three areas:
Quota - uses cgo extensively but is an optional feature with feature detection already in caller. Add a new build tag that can be used to build without it.
Copy - cgo used for the ioctl based fast copy that has been replaced with the syscall. Change is to skip this check on !cgo . The copy_file_range and fallback methods still provide the feature. As it is only used for constant I could also just hardcode it in !cgo version if we want to keep it.
Stats: uses sysconf. Replaced with
unix.SchedGetaffinity