Conversation
Reverts the change to swarmkit that made all updates set UpdateStatus to Completed Signed-off-by: Drew Erny <[email protected]>
|
Yea we need to do this for get 19.03 working correctly but this will add some flakiness back to moby integration tests which need to be fixed on some other way. @dperny I also think that we probably should add some integration test case to swarmkit side which prevents same issue coming back on future? Janky have now failed to #32673 and #38885 |
|
(reserved for my derek commands) |
|
we can try again later, but we have to be careful. in my opinion, what the CLI is doing that's causing this to be a problem is Wrong, but it's far too late to change it. |
|
Yea. Btw. On RS1 build servers looks to have some generic issue so it can be ignored here. |
|
@dperny and I were discussing this revert, and (temporarily) reverting this change seemed the best / safest option for now; we can redo the change if we find an approach tp make the cli work with it (in a backward compatible way) |
|
everything but the known bad windows test is passing. |
6 participants
- What I did
Reverts the change to swarmkit that made all updates set UpdateStatus to Completed.
See moby/swarmkit#2861
related: moby/swarmkit#2804, #38520
fixes moby/swarmkit#2861
fixes #39023
- How I did it
Returned the integration test to the way it was before