Fix error handling for bind mount spec parser.#39251
Merged
thaJeztah merged 1 commit intoMay 23, 2019
Merged
Conversation
3 tasks
Member
Author
|
Adding cherry-pick because this is a quick fix for a really confusing situation. |
cpuguy83
force-pushed
the
these_pretzels_are_making_me_thirsty
branch
from
May 21, 2019 22:59
69c6733 to
b698469
Compare
Member
|
arf; looks like it's failing on Windows; |
cpuguy83
force-pushed
the
these_pretzels_are_making_me_thirsty
branch
from
May 22, 2019 17:30
b698469 to
50d8a41
Compare
Member
Author
|
:( Github notifications are having issues, CI is not being triggered. |
Codecov Report
@@ Coverage Diff @@
## master #39251 +/- ##
=========================================
Coverage ? 37.04%
=========================================
Files ? 612
Lines ? 45489
Branches ? 0
=========================================
Hits ? 16850
Misses ? 26349
Partials ? 2290 |
Errors were being ignored and always telling the user that the path doesn't exist even if it was some other problem, such as a permission error. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
these_pretzels_are_making_me_thirsty
branch
from
May 22, 2019 18:54
50d8a41 to
ebcef28
Compare
Member
Author
|
Well, PR is fixed for Windows... Github is still being a bit funny. |
thaJeztah
approved these changes
May 22, 2019
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
janky failure is docker-py, and doesn't look related
This was referenced May 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors were being ignored and always telling the user that the path
doesn't exist even if it was some other problem, such as a permission
error.
Closes docker/for-linux#674