int-cli/TestSearchCmdOptions: fix#39243
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 21, 2019
Merged
Conversation
Merged
kolyshkin
force-pushed
the
TestSearchCmdOptions
branch
from
deb5209 to
49d488c
Compare
Codecov Report
@@ Coverage Diff @@
## master #39243 +/- ##
=========================================
Coverage ? 37.05%
=========================================
Files ? 612
Lines ? 45487
Branches ? 0
=========================================
Hits ? 16857
Misses ? 26342
Partials ? 2288 |
kolyshkin
changed the title
Sometimes this test fails (allegedly due to problems with Docker Hub), but it fails later than it should, for example: > 01:20:34.845 assertion failed: expression is false: strings.Count(outSearchCmdStars, "[OK]") <= strings.Count(outSearchCmd, "[OK]"): The quantity of images with stars should be less than that of all images: <...> This, with non-empty list of images following, means that the initial `docker search busybox` command returned not enough results. So, add a check that `docker search busybox` returns something. While at it, * raise the number of stars to 10; * simplify check for number of lines (no need to count [OK]'s); * improve error message. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
TestSearchCmdOptions
branch
from
49d488c to
4f80a19
Compare
thaJeztah
added
area/testing
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
thaJeztah
approved these changes
May 21, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
I think (most of) these tests could be converted to a unit test (i.e., just verify we create the expected request, and filtering could be done with a fixture response), because right now we're mainly testing if Docker Hub works 🤷♂
Member
|
Test passed on Janky and experimental; |
Member
|
Power and s390 also passed on that test; bringing this one in to unblock CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes this test fails (allegedly due to problems with Docker Hub, see #26633),
but it fails later than it should, for example:
This, with non-empty list of images following, means that the initial
docker search busyboxcommand returned not enough results. So, adda check that
docker search busyboxreturns something.While at it,