Vendor Libnetwork 48f8463#39018
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 9, 2019
Merged
Conversation
Signed-off-by: Madhu Venugopal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #39018 +/- ##
==========================================
- Coverage 36.89% 36.89% -0.01%
==========================================
Files 613 613
Lines 45421 45421
==========================================
- Hits 16760 16757 -3
- Misses 26370 26372 +2
- Partials 2291 2292 +1 |
thaJeztah
added
area/networking
selansen
approved these changes
Apr 8, 2019
Contributor
selansen
left a comment
selansen
left a comment
There was a problem hiding this comment.
LGTM
below error doesn't seem to be related libnetwork vendor update
22:17:44
22:17:44 assertion failed:
22:17:44 Command: /usr/local/cli/docker run -i --name test-inter-restart --restart=always busybox sh
22:17:44 ExitCode: 0
22:17:44 Error: <nil>
22:17:44 Stdout:
22:17:44 Stderr: ```
thaJeztah
reviewed
Apr 8, 2019
| } | ||
|
|
||
| func endpointRequest(method, path, request string) (*hcsshim.HNSEndpoint, error) { | ||
| if windowsBuild == 14393 { |
Member
There was a problem hiding this comment.
FWIW, I think this fix should be upstreamed to hcsshim; this is not something consumers of the hcsshim package should have to deal with; I'll have a look if I can create a patch there
Contributor
Author
There was a problem hiding this comment.
Yes. We discussed about it. Unfortunately, this pulls in a lot of vendor code which requires more integration test cases. Given the immediate release concerns, this is a good compromise to have.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit brings in moby/libnetwork#2356 and moby/libnetwork#2357. Adds a workaround for a WS2016 HNS race issue by serializing the L2 Table programming across networks.
Signed-off-by: Madhu Venugopal [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)