openrc: Modernize and sync settings#39000
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 5, 2019
Merged
Conversation
* Use rc_ulimit for ulimit constraints * Synchronize ulimit settings to systemd's * Add support for reload command * Add support for retry settings for docker stop/restart Signed-off-by: Manuel Rüger <[email protected]>
tianon
approved these changes
Apr 4, 2019
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
LGTM
@thaJeztah any reason to not merge this? (I don't think any Docker-published releases consume/use it, so any unforeseen impact would be low and the changes are definitely sane)
thaJeztah
approved these changes
Apr 5, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
seems sane to me
LGTM
I'll check if we can include this in the 19.03 release
Member
|
CI failures were unrelated (file itself is not used in CI), but just restarting them to make sure there's not a linter somewhere that fails for whatever reason 😅 |
Codecov Report
@@ Coverage Diff @@
## master #39000 +/- ##
==========================================
+ Coverage 36.9% 36.91% +<.01%
==========================================
Files 613 613
Lines 45421 45421
==========================================
+ Hits 16764 16767 +3
+ Misses 26367 26363 -4
- Partials 2290 2291 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Rüger [email protected]
@tianon might be a good candidate to review those changes.
- What I did
- How I did it
- How to verify it
Run the openrc service
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)