Open
Conversation
|
Please sign your commits following these rules: $ git clone -b "patch-1" [email protected]:wrfly/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
GordonTheTurtle
added
dco/no
GordonTheTurtle
removed
the
dco/no
Member
|
wrfly
force-pushed
the
patch-1
branch
2 times, most recently
from
ea671d0 to
41da262
Compare
Contributor
Author
12:19:11 Running /go/src/github.com/docker/docker/integration/container
12:19:12 INFO: Testing against a local daemon
12:19:12 === RUN TestCheckpoint
12:19:13 --- FAIL: TestCheckpoint (1.40s)
12:19:13 checkpoint_test.go:40: Error (criu/util.c:816): exited, status=3
12:19:13 Warn (criu/net.c:2840): Unable to get socket network namespace
12:19:13 Warn (criu/net.c:2840): Unable to get tun network namespace
12:19:13 Warn (criu/sk-unix.c:229): unix: Unable to open a socket file: Bad address
12:19:13 Warn (criu/net.c:2840): Unable to get socket network namespace
12:19:13 Warn (criu/kerndat.c:881): Can't keep kdat cache on non-tempfs
12:19:13 Looks good.
12:19:13 checkpoint_test.go:51: Start a container
12:19:13 checkpoint_test.go:69: ++ type -P true
12:19:13 ++ type -P ip6tables-restore
12:19:13 + mount --bind /bin/true /sbin/ip6tables-restore
12:19:13 ++ type -P true
12:19:13 ++ type -P ip6tables-save
12:19:13 + mount --bind /bin/true /sbin/ip6tables-save
12:19:13 checkpoint_test.go:81: Do a checkpoint and leave the container running
12:19:13 checkpoint_test.go:24: Exec: [touch /tmp/test-file]
12:19:13 checkpoint_test.go:28:
12:19:13 checkpoint_test.go:115: Do a checkpoint and stop the container
12:19:13 checkpoint_test.go:117: assertion failed: error is not nil: Error response from daemon: Cannot checkpoint container 43f78e035e72f94c024d640591806641ad7628485dc656c13b01f660228fe98e: cannot checkpoint a stopped container: unknown
12:19:13 checkpoint_test.go:77: ++ type -P ip6tables-restore
12:19:13 + umount -c -i -l /sbin/ip6tables-restore
12:19:13 ++ type -P ip6tables-save
12:19:13 + umount -c -i -l /sbin/ip6tables-save
12:19:13 main_test.go:32: assertion failed: error is not nil: Error response from daemon: Container 43f78e035e72f94c024d640591806641ad7628485dc656c13b01f660228fe98e is not paused: failed to unpause container 43f78e035e72f94c024d640591806641ad7628485dc656c13b01f660228fe98eIs that matter? |
thaJeztah
reviewed
Mar 27, 2019
client/events_test.go
Outdated
Member
There was a problem hiding this comment.
Wouldn't this mean the test could complete without receiving a single of the expected events?
Contributor
Author
There was a problem hiding this comment.
You are right, I'll modify it, thx.
Codecov Report
@@ Coverage Diff @@
## master #38939 +/- ##
=========================================
Coverage ? 36.89%
=========================================
Files ? 614
Lines ? 45405
Branches ? 0
=========================================
Hits ? 16753
Misses ? 26360
Partials ? 2292 |
Contributor
Author
|
How can I re-test it? |
Member
|
ping @cpuguy83 ptal |
SamWhited
reviewed
Oct 31, 2019
close the receive-only events channel after error happends Signed-off-by: wrfly <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think you guys forgot to close the message event channel since no one can close it outside due to the receive-only channel type.