TestDaemonRestartIpcMode: move to integration#38843
Merged
yongtang merged 4 commits intomoby:masterfrom Mar 9, 2019
Merged
Conversation
Signed-off-by: Kir Kolyshkin <[email protected]>
Since container.Create() already initializes HostConfig to be non-nil, there is no need for this code. Remove it. Signed-off-by: Kir Kolyshkin <[email protected]>
NOTE TestUpdateRestartPolicy is left as is as otherwise it will decrease its readability. Signed-off-by: Kir Kolyshkin <[email protected]>
Move the test case from integration-cli to integration. The test logic itself has not changed, except these two things: * the new test sets default-ipc-mode via command line rather than via daemon.json (less code); * the new test uses current API version. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
Windows CI timed out. Let's see if Derek understands commands in the middle of the text. Derek add label: rebuild/windowsRS1 |
Contributor
Author
|
Derek add label: rebuild/windowsRS1 |
Codecov Report
@@ Coverage Diff @@
## master #38843 +/- ##
=========================================
Coverage ? 36.46%
=========================================
Files ? 613
Lines ? 45814
Branches ? 0
=========================================
Hits ? 16707
Misses ? 26824
Partials ? 2283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core of this PR is last commit, which moves the
TestDaemonRestartIpcModetest case from integration-cli to integration. The test logic itself has not changed, except these two things:Other commits are some minor cleanups; please see individual commit descriptions for details.