service: support --mount type=bind,bind-nonrecursive#38788
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Mar 13, 2020
Merged
service: support --mount type=bind,bind-nonrecursive#38788cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
AkihiroSuda
force-pushed
the
bind-nonrecursive-swarm
branch
from
17a1587 to
9e81db6
Compare
AkihiroSuda
commented
Feb 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #38788 +/- ##
=========================================
Coverage ? 36.43%
=========================================
Files ? 613
Lines ? 45854
Branches ? 0
=========================================
Hits ? 16707
Misses ? 26854
Partials ? 2293 |
Member
Author
|
@cpuguy83 PTAL? |
Member
|
ping @kolyshkin @cpuguy83 PTAL 🙏 |
tonistiigi
approved these changes
Oct 3, 2019
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
ping @cpuguy83
@AkihiroSuda You have to repush, apparently there is no way to trigger ci rebuilds in this new ci system.
AkihiroSuda
force-pushed
the
bind-nonrecursive-swarm
branch
from
9e81db6 to
0599390
Compare
Member
Author
|
ping @tonistiigi @cpuguy83 |
thaJeztah
reviewed
Dec 13, 2019
AkihiroSuda
changed the title
AkihiroSuda
force-pushed
the
bind-nonrecursive-swarm
branch
3 times, most recently
from
b652923 to
19f897b
Compare
AkihiroSuda
force-pushed
the
bind-nonrecursive-swarm
branch
from
19f897b to
591dd3e
Compare
AkihiroSuda
changed the title
Member
Author
|
addressed comments |
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
bind-nonrecursive-swarm
branch
from
591dd3e to
745fa04
Compare
thaJeztah
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #38003 for services
Signed-off-by: Akihiro Suda [email protected]
- What I did
Support
docker service create --mount type=bind,bind-nonrecursive- How I did it
Updated
daemon/cluster- How to verify it
- Description for the changelog
service: support --mount type=bind,bind-nonrecursive
- A picture of a cute animal (not mandatory but encouraged)
🐧