hack: Have TIMEOUT take -test.count into account when testing for flakiness#38693
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Feb 8, 2019
Merged
hack: Have TIMEOUT take -test.count into account when testing for flakiness#38693cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
tiborvass
force-pushed
the
fix-timeout-bug
branch
from
b16593d to
2568285
Compare
Codecov Report
@@ Coverage Diff @@
## master #38693 +/- ##
==========================================
- Coverage 36.56% 36.52% -0.04%
==========================================
Files 610 610
Lines 45395 45395
==========================================
- Hits 16598 16581 -17
- Misses 26505 26517 +12
- Partials 2292 2297 +5 |
Contributor
Author
|
This fixes a failure when TESTARRAY in hack/make/test-integration-flaky includes |
…kiness Signed-off-by: Tibor Vass <[email protected]>
tiborvass
force-pushed
the
fix-timeout-bug
branch
from
2568285 to
42dcfc8
Compare
tiborvass
changed the title
thaJeztah
approved these changes
Feb 8, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks for the added comment
Contributor
|
@tiborvass this is why I like open source so much. I can introduce idea and then someone else will improve it. Awesome and thanks 😀 |
Contributor
Author
|
@olljanat thanks :) feel free to approve and merge! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to https://github.com/moby/moby/pull/38523/files#r254905817
Ping @olljanat @thaJeztah @tianon @vdemeester