Allow overriding repository and branch in validate scripts#38655
Allow overriding repository and branch in validate scripts#38655tianon merged 1 commit intomoby:masterfrom
Conversation
|
ping @tianon PTAL I was looking for a way to programatically figure out what the "target" branch ( If so, that would ease configuration (i.e., no need to configure these environment variables) |
Just to proxy some of my thoughts back from our Slack conversation for posterity:
|
When running CI in other repositories (e.g. Docker's downstream docker/engine repository), or other branches, the validation scripts were calculating the list of changes based on the wrong information. This lead to weird failures in CI in a branch where these values were not updated ':-) (CI on a pull request failed because it detected that new tests were added to the deprecated `integration-cli` test-suite, but the pull request did not actually make changes in that area). This patch allows overriding the target repository (and branch) to compare to (without having to edit the scripts). Signed-off-by: Sebastiaan van Stijn <[email protected]>
2d279b7 to
2a08f33
Compare
Codecov Report
@@ Coverage Diff @@
## master #38655 +/- ##
=========================================
Coverage ? 36.58%
=========================================
Files ? 610
Lines ? 45217
Branches ? 0
=========================================
Hits ? 16541
Misses ? 26396
Partials ? 2280 |
|
@tianon LGTY? 🤗 |
|
LGTM |
When running CI in other repositories (e.g. Docker's downstream
docker/engine repository), or other branches, the validation
scripts were calculating the list of changes based on the wrong
information.
This lead to weird failures in CI in a branch where these values
were not updated ':-) (CI on a pull request failed because it detected
that new tests were added to the deprecated
integration-clitest-suite,but the pull request did not actually make changes in that area).
This patch allows overriding the target repository (and branch)
to compare to (without having to edit the scripts).