Integration tests: remove some duplicated code, and preserve context#38557
Merged
vdemeester merged 2 commits intomoby:masterfrom Jan 15, 2019
Merged
Integration tests: remove some duplicated code, and preserve context#38557vdemeester merged 2 commits intomoby:masterfrom
vdemeester merged 2 commits intomoby:masterfrom
Conversation
Member
Author
|
Something fishy: (also see the other PR); Logs from that daemon: |
Clean up and refactor this test; - make `serviceRunningTasksCount` to use a `desired-state` filter - use subtests, and inline the `validNetworkVerbose` checks; also use asserts for the individual checks, so that any failure will log exactly what failed - remove helper functions that are no longer needed Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_duplicated_code
branch
from
dbe38b7 to
a00da59
Compare
Codecov Report
@@ Coverage Diff @@
## master #38557 +/- ##
=========================================
Coverage ? 36.66%
=========================================
Files ? 608
Lines ? 45173
Branches ? 0
=========================================
Hits ? 16562
Misses ? 26330
Partials ? 2281 |
thaJeztah
force-pushed
the
remove_duplicated_code
branch
from
a00da59 to
15aaa03
Compare
This introduces `NoTasksForService` and `NoTasks` poller checks, that can be used to check if no tasks are left in general, or for a specific service. Some redundant checks were also removed from some tests. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_duplicated_code
branch
from
15aaa03 to
56a68c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #38556 (this one is based on top of that)
This introduces
NoTasksForServiceandNoTaskspoller checks, thatcan be used to check if no tasks are left in general, or for a specific
service.
Some redundant checks were also removed from some tests.