Merged
Conversation
thaJeztah
added
status/failing-ci
Member
Author
|
oh... hmm... Wondering what's happening here; other tests are failing. I have a suspicion what's happening; even though each test spins up a new daemon, the daemon is only stopped afterwards, but not removed (nor their containers/tasks removed). I wonder if those tasks are still lingering around somewhere (e.g. a new containerd instance picking them up?) |
Member
Author
|
Actually not sure that makes sense; still; looks like something is shared between those daemons, and some state is preserved 🤔 |
Member
Author
|
For fun, running these while running the integration tests; |
thaJeztah
added
rebuild/*
and removed
status/failing-ci
thaJeztah
force-pushed
the
cleanup_inspect_test
branch
from
f81406a to
7b9aeca
Compare
Codecov Report
@@ Coverage Diff @@
## master #38556 +/- ##
=========================================
Coverage ? 36.64%
=========================================
Files ? 608
Lines ? 45173
Branches ? 0
=========================================
Hits ? 16553
Misses ? 26336
Partials ? 2284 |
thaJeztah
force-pushed
the
cleanup_inspect_test
branch
2 times, most recently
from
f9f06c1 to
322a3d5
Compare
Clean up and refactor this test; - make `serviceRunningTasksCount` to use a `desired-state` filter - use subtests, and inline the `validNetworkVerbose` checks; also use asserts for the individual checks, so that any failure will log exactly what failed - remove helper functions that are no longer needed Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
cleanup_inspect_test
branch
from
322a3d5 to
60d93aa
Compare
thaJeztah
commented
Jan 14, 2019
| } | ||
|
|
||
| err = client.ServiceRemove(context.Background(), serviceID2) | ||
| // TODO find out why removing networks is needed; other tests fail if the network is not removed, even though they run on a new daemon. |
Member
Author
There was a problem hiding this comment.
I put back the remove step, but added a TODO; we should figure out what is left behind after the daemon is stopped; possibly some network cleanup that's needed on shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up and refactor this test;
serviceRunningTasksCountto use adesired-statefiltervalidNetworkVerbosechecks; also useasserts for the individual checks, so that any failure will log exactly
what failed
don't cleanup services and networks afterwards, as the daemon is only used during this test.