Make TestEventsFilterLabels less flaky#38552
Merged
vdemeester merged 1 commit intomoby:masterfrom Jan 15, 2019
Merged
Conversation
Member
Author
|
oh, dang; forgot to update a value again lol |
thaJeztah
force-pushed
the
improve_test_events_filter_labels
branch
from
15c4101 to
92dca65
Compare
Codecov Report
@@ Coverage Diff @@
## master #38552 +/- ##
=========================================
Coverage ? 36.65%
=========================================
Files ? 608
Lines ? 45173
Branches ? 0
=========================================
Hits ? 16557
Misses ? 26333
Partials ? 2283 |
Member
Author
|
hmmm.. forgot that it will now wait for the "until" time to expire; updating |
thaJeztah
force-pushed
the
improve_test_events_filter_labels
branch
from
92dca65 to
b9fc518
Compare
This test sometimes failed because the number of events received did not
match the expected number:
FAIL: docker_cli_events_test.go:316: DockerSuite.TestEventsFilterLabels
docker_cli_events_test.go:334:
c.Assert(len(events), checker.Equals, 3)
... obtained int = 2
... expected int = 3
This patch makes the test more stable, by:
- use a wider range between `--since` and `--until`. These options were set
so that the client detaches after events were received, but the actual
range should not matter. Changing the range will cause more events to be
returned, but we're specifically looking for the container ID's, so this
should not make a difference for the actual test.
- use `docker create` instead of `docker run` for the containers. the
containers don't have to be running to trigger an event; using `create`
speeds up the test.
- check the exit code of the `docker create` to verify the containers were
succesfully created.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
improve_test_events_filter_labels
branch
from
b9fc518 to
0e15c02
Compare
tiborvass
approved these changes
Jan 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22814
This test sometimes failed because the number of events received did not
match the expected number:
This patch makes the test more stable, by:
--sinceand--until. These options were setso that the client detaches after events were received, but the actual
range should not matter. Changing the range will cause more events to be
returned, but we're specifically looking for the container ID's, so this
should not make a difference for the actual test.
docker createinstead ofdocker runfor the containers. thecontainers don't have to be running to trigger an event; using
createspeeds up the test.
docker createto verify the containers weresuccesfully created.