Shell scripts: remove bashisms and fix bare variables#38527
Merged
thaJeztah merged 2 commits intomoby:masterfrom Jan 11, 2019
Merged
Shell scripts: remove bashisms and fix bare variables#38527thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
…otes" This reverts commit 297b30d. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This makes my IDE a bit more silent :-) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @tianon 👍 ❤️ |
tao12345666333
approved these changes
Jan 10, 2019
Contributor
|
(reserved for my derek commands) |
Codecov Report
@@ Coverage Diff @@
## master #38527 +/- ##
=========================================
Coverage ? 36.66%
=========================================
Files ? 608
Lines ? 45174
Branches ? 0
=========================================
Hits ? 16562
Misses ? 26329
Partials ? 2283 |
Member
Author
|
💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #38424, and re-applies the non-double-bracket-changes-etcetera