Skip to content

Use poll.WaitOn in authz_plugin_test.go#38515

Merged
thaJeztah merged 1 commit intomoby:masterfrom
yongtang:01082019-oll.WaitOn
Jan 9, 2019
Merged

Use poll.WaitOn in authz_plugin_test.go#38515
thaJeztah merged 1 commit intomoby:masterfrom
yongtang:01082019-oll.WaitOn

Conversation

@yongtang
Copy link
Member

@yongtang yongtang commented Jan 9, 2019

This fix uses poll.WaitOn to replace customerized implementation in authz_plugin_test.go

Signed-off-by: Yong Tang [email protected]

This fix uses poll.WaitOn to replace customerized
implementation in authz_plugin_test.go

Signed-off-by: Yong Tang <[email protected]>
@olljanat
Copy link
Contributor

olljanat commented Jan 9, 2019

@yongtang you maybe would like to look #38499 as it fixes tests which fails on Z

EDIT: it was merged so will try run Z again.

@olljanat
Copy link
Contributor

olljanat commented Jan 9, 2019

(reserved for my derek commands)

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #38515 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38515      +/-   ##
==========================================
- Coverage   36.65%   36.63%   -0.03%     
==========================================
  Files         608      608              
  Lines       45174    45174              
==========================================
- Hits        16560    16550      -10     
- Misses      26329    26336       +7     
- Partials     2285     2288       +3

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants