TestRenameAnonymousContainer: fix error msg#38490
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 5, 2019
Merged
Conversation
A recent CI run shows a (seemingly random) failure from this test:
> 00:14:37.289 --- FAIL: TestRenameAnonymousContainer (1.75s)
> 00:14:37.289 rename_test.go:169: assertion failed: 0 (int) != 1 (inspect.State.ExitCode int): container baac251d5a1cb2221ffedf6f10acbad166b90e3549601e96d908e76762675a81 exited with the wrong exitcode: {ContainerJSONBase:0xc0007a4840 Mounts:[] Config:0xc000714500 NetworkSettings:0xc000235b00}
Apparently, printing the whole `inspect` value does not make any sense.
Let's output `inspect.State.Error` instead, maybe it will help to
figure out what is going on here.
Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
|
Derek add label: rebuild/janky |
Member
|
Janky is a flaky test; I'll try once more |
Codecov Report
@@ Coverage Diff @@
## master #38490 +/- ##
=========================================
Coverage ? 36.7%
=========================================
Files ? 608
Lines ? 45195
Branches ? 0
=========================================
Hits ? 16587
Misses ? 26322
Partials ? 2286 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent CI run (https://jenkins.dockerproject.org/job/Docker-PRs-experimental/43541/console, from #38452) shows a (seemingly random) failure from this test:
Apparently, printing the whole
inspectvalue does not make any sense.Let's output
inspect.State.Errorinstead, maybe it will help tofigure out what is going on here.
Signed-off-by: Kir Kolyshkin [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)