Skip to content

Remove use of deprecated client.NewEnvClient()#38486

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:dont_use_deprecated_envclient
Jan 5, 2019
Merged

Remove use of deprecated client.NewEnvClient()#38486
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:dont_use_deprecated_envclient

Conversation

@thaJeztah
Copy link
Member

No description provided.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😻

@olljanat
Copy link
Contributor

olljanat commented Jan 4, 2019

Derek add label: rebuild/z

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🎖️

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2b7e084). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #38486   +/-   ##
=========================================
  Coverage          ?   36.69%           
=========================================
  Files             ?      608           
  Lines             ?    45078           
  Branches          ?        0           
=========================================
  Hits              ?    16541           
  Misses            ?    26253           
  Partials          ?     2284

@thaJeztah thaJeztah merged commit 55b5b8d into moby:master Jan 5, 2019
@thaJeztah thaJeztah deleted the dont_use_deprecated_envclient branch January 5, 2019 10:23
listx pushed a commit to listx/k8s-addon-builder that referenced this pull request Jun 19, 2021
This has been deprecated since moby/moby#38486.
See moby/moby#40185 for more context.
listx pushed a commit to listx/k8s-addon-builder that referenced this pull request Jun 19, 2021
This has been deprecated since moby/moby#38486.
See moby/moby#40185 for more context.
listx pushed a commit to listx/k8s-addon-builder that referenced this pull request Jun 19, 2021
This has been deprecated since moby/moby#38486.
See moby/moby#40185 for more context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants