Skip to content

Improve consistency in skipping tests#38482

Merged
thaJeztah merged 4 commits intomoby:masterfrom
thaJeztah:skip_consistently
Jan 7, 2019
Merged

Improve consistency in skipping tests#38482
thaJeztah merged 4 commits intomoby:masterfrom
thaJeztah:skip_consistently

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 3, 2019

Just some nits; see the individual commits for details

@thaJeztah thaJeztah requested a review from vdemeester January 3, 2019 12:10
fntlnz
fntlnz approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fntlnz
Copy link
Contributor

fntlnz commented Jan 3, 2019 •
edited
Loading

Test failing for windowsRS5-process:

12:59:11 
12:59:11 ----------------------------------------------------------------------
12:59:11 FAIL: check_test.go:107: DockerSuite.TearDownTest
12:59:11 
12:59:11 assertion failed: error is not nil: error during connect: Get http://127.0.0.1:2357/v1.40/containers/json?all=1&limit=0: dial tcp 127.0.0.1:2357: connectex: No connection could be made because the target machine actively refused it.: failed to list containers

I don't think it's related to your changes.

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 3, 2019

Hm, failing again, so perhaps it is related 🤔

12:59:11 FAIL: check_test.go:107: DockerSuite.TearDownTest
12:59:11 
12:59:11 assertion failed: error is not nil: error during connect: Get http://127.0.0.1:2357/v1.40/containers/json?all=1&limit=0: dial tcp 127.0.0.1:2357: connectex: No connection could be made because the target machine actively refused it.: failed to list containers
12:59:11 assertion failed: error is not nil: error during connect: Get http://127.0.0.1:2357/v1.40/images/json: dial tcp 127.0.0.1:2357: connectex: No connection could be made because the target machine actively refused it.: failed to list images
12:59:11 assertion failed: error is not nil: error during connect: Get http://127.0.0.1:2357/v1.40/volumes: dial tcp 127.0.0.1:2357: connectex: No connection could be made because the target machine actively refused it.: failed to list volumes
12:59:11 assertion failed: error is not nil: error during connect: Get http://127.0.0.1:2357/v1.40/networks: dial tcp 127.0.0.1:2357: connectex: No connection could be made because the target machine actively refused it.: failed to list networks
12:59:11 
12:59:11 ----------------------------------------------------------------------
12:59:11 PANIC: docker_cli_run_test.go:1791: DockerSuite.TestRunInteractiveWithRestartPolicy
12:59:11 
12:59:11 assertion failed: 
12:59:11 Command:  d:\CI\CI-cc99654c7e\binary\docker.exe stop test-inter-restart
12:59:11 ExitCode: 1
12:59:11 Error:    exit status 1
12:59:11 Stdout:   
12:59:11 Stderr:   error during connect: Post http://127.0.0.1:2357/v1.30/containers/test-inter-restart/stop: read tcp 127.0.0.1:64033->127.0.0.1:2357: wsarecv: An existing connection was forcibly closed by the remote host.
12:59:11 
12:59:11 
12:59:11 Failures:
12:59:11 ExitCode was 1 expected 0
12:59:11 Expected no error
12:59:11 ... Panic: Fixture has panicked (see related PANIC)
12:59:11

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 3, 2019

hm, I didn't touch that file, wondering if it failed to cleanup a daemon (e.g.)

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 3, 2019

ah, never mind; it wasn't restarted the first time; used rebuild/* this time, and looks to be running again now; 🤞

@codecov
Copy link

codecov bot commented Jan 3, 2019 •
edited
Loading

Codecov Report

Merging #38482 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38482      +/-   ##
==========================================
+ Coverage   36.62%   36.68%   +0.06%     
==========================================
  Files         608      608              
  Lines       45174    45195      +21     
==========================================
+ Hits        16545    16582      +37     
+ Misses      26340    26329      -11     
+ Partials     2289     2284       -5

@olljanat
Copy link
Contributor

olljanat commented Jan 5, 2019

@thaJeztah needs a rebase

@thaJeztah
Improve consistency in "skip"
a3948d1 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Only build IPCmode tests on Linux
8422493 
These tests can only be run on a local Linux daemon, so there's
no need to build them on Windows

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Simplify skip checks
69c0b7e 
These tests are run on a local Linux daemon only, so no need
to do a platform-check.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Fix some minor wording / issues
263e28a 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 7, 2019

rebased 👍

@thaJeztah
Copy link
Member Author

thaJeztah commented Jan 7, 2019

merging; powerpc failure is a known flaky test (TestSwarmLockUnlockCluster) and not related

@thaJeztah thaJeztah merged commit e859282 into moby:master Jan 7, 2019
@thaJeztah thaJeztah deleted the skip_consistently branch January 7, 2019 22:20
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

+1 more reviewer

@fntlnz fntlnz fntlnz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah @fntlnz @olljanat @AkihiroSuda @GordonTheTurtle