Run TestImportExtremelyLargeImageWorks in parallel#38480
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Jan 6, 2019
Merged
Run TestImportExtremelyLargeImageWorks in parallel#38480AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
vdemeester
approved these changes
Jan 3, 2019
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐯 on commit 4836f5969317f7be52d9c425e00f7b4c988306a8 👼
This is a slow test, taking over two minutes to complete, so spin up a new daemon for this test and run it in parallel Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
run_slow_test_parallel
branch
from
4836f59 to
ae3ca7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #38480 +/- ##
=========================================
Coverage ? 36.71%
=========================================
Files ? 608
Lines ? 45078
Branches ? 0
=========================================
Hits ? 16551
Misses ? 26247
Partials ? 2280 |
Member
Author
|
rebased to get rid of the commits from #38473 |
AkihiroSuda
approved these changes
Jan 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slow test, taking over two minutes to complete, so spin up a new daemon for this test and run it in parallel.
follow-up to #38473 (see #38473 (comment));
I'll rebase once that PR is merged