Skip to content

Fix code typo error#38459

Merged
thaJeztah merged 1 commit intomoby:masterfrom
JoeWrightss:patch-2
Jan 13, 2019
Merged

Fix code typo error#38459
thaJeztah merged 1 commit intomoby:masterfrom
JoeWrightss:patch-2

Conversation

@JoeWrightss
Copy link
Copy Markdown
Contributor

@JoeWrightss JoeWrightss commented Dec 31, 2018

Fix typo: "nameAssocation" to "nameAssociation" in line 476.

@derek derek Bot added the rebuild/* label Dec 31, 2018
@olljanat
Copy link
Copy Markdown
Contributor

olljanat commented Dec 31, 2018

Z failed to error which I have not seen earlier:

09:15:34 FAIL: docker_cli_push_test.go:203: DockerSchema1RegistrySuite.TestConcurrentPush
09:15:34 
09:15:34 docker_cli_push_test.go:204:
09:15:34     testConcurrentPush(c)
09:15:34 docker_cli_push_test.go:183:
09:15:34     c.Assert(err, checker.IsNil, check.Commentf("concurrent push failed with error: %v", err))
09:15:34 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc000c77380), Stderr:[]uint8(nil)} ("exit status 1")
09:15:34 ... concurrent push failed with error: exit status 1

Let's try again...

@derek derek Bot added the rebuild/z label Dec 31, 2018
@olljanat
Copy link
Copy Markdown
Contributor

olljanat commented Dec 31, 2018

And now RS1 failed to error which I have not seen earlier:

10:58:35 FAIL: docker_cli_start_test.go:189: DockerSuite.TestStartReturnCorrectExitCode
10:58:35 
10:58:35 docker_cli_start_test.go:199:
10:58:35     c.Assert(exitCode, checker.Equals, 12, check.Commentf("out: %s", out))
10:58:35 ... obtained int = 125
10:58:35 ... expected int = 12
10:58:35 ... out: time="2018-12-31T10:58:35Z" level=error msg="error waiting for container: EOF"

@derek derek Bot added the rebuild/z label Dec 31, 2018
@olljanat
Copy link
Copy Markdown
Contributor

olljanat commented Dec 31, 2018

Some other new error on RS1. Weird:

11:19:13 2018/12/31 11:18:40 http: panic serving 127.0.0.1:49219: Plugin not ready
11:19:13 goroutine 40 [running]:
11:19:13 net/http.(*conn).serve.func1(0xc000140000)
11:19:13 	c:/go/src/net/http/server.go:1746 +0xd7
11:19:13 panic(0x7eb7c0, 0x8f3fc0)
11:19:13 	c:/go/src/runtime/panic.go:513 +0x1c7
11:19:13 github.com/docker/docker/pkg/plugins.TestFailOnce.func1(0x8fbf20, 0xc00014c000, 0xc000128200)
11:19:13 	c:/go/src/github.com/docker/docker/pkg/plugins/client_test.go:55 +0x56
11:19:13 net/http.HandlerFunc.ServeHTTP(0xc00010c070, 0x8fbf20, 0xc00014c000, 0xc000128200)
11:19:13 	c:/go/src/net/http/server.go:1964 +0x4b
11:19:13 net/http.(*ServeMux).ServeHTTP(0xc000104150, 0x8fbf20, 0xc00014c000, 0xc000128200)
11:19:13 	c:/go/src/net/http/server.go:2361 +0x12e
11:19:13 net/http.serverHandler.ServeHTTP(0xc00012c000, 0x8fbf20, 0xc00014c000, 0xc000128200)
11:19:14 	c:/go/src/net/http/server.go:2741 +0xb2
11:19:14 net/http.(*conn).serve(0xc000140000, 0x8fc2a0, 0xc000110180)
11:19:14 	c:/go/src/net/http/server.go:1847 +0x64d
11:19:14 created by net/http.(*Server).Serve
11:19:14 	c:/go/src/net/http/server.go:2851 +0x2fc
11:19:14 time="2018-12-31T11:18:40Z" level=warning msg="Unable to connect to plugin: 127.0.0.1:49218/Test.FailOnce: Post http://127.0.0.1:49218/Test.FailOnce: EOF, retrying in 1s"
11:19:14 time="2018-12-31T11:18:41Z" level=warning msg="Unable to connect to plugin: 127.0.0.1:49223/Test.Echo: Post http://127.0.0.1:49223/Test.Echo: net/http: request canceled (Client.Timeout exceeded while awaiting headers), retrying in 1s"
11:19:14 time="2018-12-31T11:18:43Z" level=warning msg="Unable to connect to plugin: 127.0.0.1:49223/Test.Echo: Post http://127.0.0.1:49223/Test.Echo: net/http: request canceled (Client.Timeout exceeded while awaiting headers), retrying in 2s"
11:19:14 time="2018-12-31T11:18:45Z" level=warning msg="Unable to connect to plugin: 127.0.0.1:49223/Test.Echo: Post http://127.0.0.1:49223/Test.Echo: net/http: request canceled (Client.Timeout exceeded while awaiting headers), retrying in 4s"
11:19:14 time="2018-12-31T11:18:50Z" level=warning msg="Unable to connect to plugin: 127.0.0.1:49223/Test.Echo: Post http://127.0.0.1:49223/Test.Echo: net/http: request canceled (Client.Timeout exceeded while awaiting headers), retrying in 8s"
11:19:14 --- FAIL: TestClientWithRequestTimeout (0.00s)
11:19:14     client_test.go:259: assertion failed: 
11:19:14         --- context.DeadlineExceeded
11:19:14         +++ err
11:19:14         :
11:19:14         	-: context.deadlineExceededError{}
11:19:14         	+: &net.OpError{Op: "dial", Net: "tcp", Addr: s"127.0.0.1:49294", Err: &poll.TimeoutError{}}
11:19:14         
11:19:14 time="2018-12-31T11:18:58Z" level=warning msg="Unable to locate plugin: vegetable, retrying in 1s"
11:19:14 time="2018-12-31T11:18:59Z" level=warning msg="Unable to locate plugin: vegetable, retrying in 2s"
11:19:14 time="2018-12-31T11:19:01Z" level=warning msg="Unable to locate plugin: vegetable, retrying in 4s"
11:19:14 time="2018-12-31T11:19:05Z" level=warning msg="Unable to locate plugin: vegetable, retrying in 8s"
11:19:14 FAIL
11:19:14 coverage: 73.6% of statements
11:19:14 FAIL	github.com/docker/docker/pkg/plugins	34.918s

@olljanat
Copy link
Copy Markdown
Contributor

olljanat commented Jan 1, 2019

Weird. RS1 does not like this PR at all.

15:52:45 FAIL: check_test.go:107: DockerSuite.TearDownTest
15:52:45 
15:52:45 assertion failed: error is not nil: Error response from daemon: container 73045cbd60b3b5a795bf285b94ca2ea8d1a7aaae2b1bef4a9ade93b2d72ca956: driver "windowsfilter" failed to remove root filesystem: hcsshim::GetComputeSystems: Access is denied.: failed to remove 73045cbd60b3b5a795bf285b94ca2ea8d1a7aaae2b1bef4a9ade93b2d72ca956
15:52:45 
15:52:45 ----------------------------------------------------------------------
15:52:45 PANIC: docker_cli_start_test.go:189: DockerSuite.TestStartReturnCorrectExitCode
15:52:45 
15:52:45 docker_cli_start_test.go:199:
15:52:45     c.Assert(exitCode, checker.Equals, 12, check.Commentf("out: %s", out))
15:52:45 ... obtained int = 125
15:52:45 ... expected int = 12
15:52:45 ... out: time="2018-12-31T15:52:34Z" level=error msg="error waiting for container: EOF" 
15:52:45 
15:52:45 
15:52:45 ... Panic: Fixture has panicked (see related PANIC)

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 1, 2019 •
edited
Loading

Codecov Report

Merging #38459 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #38459      +/-   ##
==========================================
- Coverage   36.64%   36.55%   -0.09%     
==========================================
  Files         608      608              
  Lines       45173    45040     -133     
==========================================
- Hits        16553    16464      -89     
+ Misses      26339    26296      -43     
+ Partials     2281     2280       -1

vdemeester
vdemeester approved these changes Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯
/cc @thaJeztah

thaJeztah
thaJeztah requested changes Jan 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, but the sign-off may have to be fixed;

@JoeWrightss could you make sure your sign-off is using your real name, not your GitHub alias?

Signed-off-by: JoeWrightss <[email protected]>

@JoeWrightss
fix code typo
89e3a4a 
Signed-off-by: zhoulin xie <[email protected]>
@JoeWrightss
Copy link
Copy Markdown
Contributor Author

JoeWrightss commented Jan 11, 2019

@thaJeztah , thank you for your reminding, and I have change my sign-off in my real name now.

thaJeztah
thaJeztah approved these changes Jan 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit ebc0750 into moby:master Jan 13, 2019
@elboulangero elboulangero mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoeWrightss @olljanat @vdemeester @thaJeztah @GordonTheTurtle