Skip to content

Replace deprecated client.WithDialer()#38445

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:dont_use_deprecated_withdialer
Dec 29, 2018
Merged

Replace deprecated client.WithDialer()#38445
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:dont_use_deprecated_withdialer

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 28, 2018

@thaJeztah
Replace deprecated client.WithDialer()
8d3fecc 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
vdemeester
vdemeester approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 29, 2018

This file isn't built on Windows, and RS5 failure is due to the machine needing a cleanup;

INFO: Nuke-Everything...
15:17:14 INFO: Container count on control daemon to delete is 1
15:17:14 437eae58a51c
15:17:14 INFO: Non-base image count on control daemon to delete is 41
15:17:14 INFO: Killing daemon with PID 25476
15:17:14 INFO: Tidying pidfile d:\CI\CI-e0270817ef\docker.pid
15:17:14 INFO: Stopping possible daemon pid 25476
15:17:15 INFO: Nuking d:\CI
15:17:17 ERROR:  hcsshim::DestroyLayer - Win32 API call returned error r1=0x80070020 err=The process cannot access the file because it is being used by another process.id=CI flavour=0

@thaJeztah thaJeztah merged commit 53bb992 into moby:master Dec 29, 2018
@thaJeztah thaJeztah deleted the dont_use_deprecated_withdialer branch December 29, 2018 09:47
@thaJeztah thaJeztah mentioned this pull request Apr 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/testing status/4-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @vdemeester @AkihiroSuda @GordonTheTurtle