Skip to content

Remove old ExperimentalDaemon, NotS390X, NotPausable, SameHostDaemon checks#38426

Merged
AkihiroSuda merged 2 commits intomoby:masterfrom
thaJeztah:remove_unused_experimental_check
Dec 25, 2018
Merged

Remove old ExperimentalDaemon, NotS390X, NotPausable, SameHostDaemon checks#38426
AkihiroSuda merged 2 commits intomoby:masterfrom
thaJeztah:remove_unused_experimental_check

Conversation

@thaJeztah
Copy link
Member

These were either unused, or could be replaced with their testenv counterpart

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@olljanat
Copy link
Contributor

@vdemeester @yongtang PowerPC failed once more to flaky test TestAPISwarmLeaderElection. I recommend that you merge this one and look my PR #38423 which actually disables that test from PowerPC.

@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #38426 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #38426      +/-   ##
==========================================
+ Coverage   36.55%   36.62%   +0.06%     
==========================================
  Files         608      608              
  Lines       45036    45185     +149     
==========================================
+ Hits        16465    16549      +84     
- Misses      26293    26352      +59     
- Partials     2278     2284       +6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants